[GitHub] [solr] tflobbe commented on pull request #1504: SOLR-7609 ShardSplitTest NPE investigation

["tflobbe (via GitHub)" <gi...@apache.org>]

tflobbe commented on PR #1504:
URL: https://github.com/apache/solr/pull/1504#issuecomment-1520829973

   > I believe the intent could have been to check docCollection for null instead of collection?
   
   +1, this seems like a bug.
   
   > all over the class there is a pattern of checking read only status to prevent some operations I believe could be broken.
   
   I'd have to look this a bit more, but you are probably right. Probably deserves it's own PR?
   
   Let's merge this PR. @stillalex, can you push the `CHANGES.txt`? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org