[GitHub] [pulsar] lhotari commented on a diff in pull request #17873: [branch-2.11] Ensure JDK8 compatibilty for Pulsar java clients

[GitBox <gi...@apache.org>]

lhotari commented on code in PR #17873:
URL: https://github.com/apache/pulsar/pull/17873#discussion_r982426664


##########
pulsar-client-all/pom.xml:
##########
@@ -397,6 +397,33 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-enforcer-plugin</artifactId>
+        <version>${maven-enforcer-plugin.version}</version>
+        <executions>
+          <execution>
+            <id>enforce-bytecode-version</id>
+            <goals>
+              <goal>enforce</goal>
+            </goals>
+            <configuration>
+              <rules>
+                <enforceBytecodeVersion>
+                  <maxJdkVersion>1.8</maxJdkVersion>

Review Comment:
   I guess it would be consistent to use the `pulsar.client.compiler.release` property
   ```suggestion
                     <maxJdkVersion>${pulsar.client.compiler.release}</maxJdkVersion>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org