You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Chris Darroch (JIRA)" <ji...@apache.org> on 2009/02/10 23:21:59 UTC

[jira] Created: (ZOOKEEPER-309) core dump using zoo_get_acl()

core dump using zoo_get_acl() 
------------------------------

                 Key: ZOOKEEPER-309
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
             Project: Zookeeper
          Issue Type: Bug
          Components: c client
            Reporter: Chris Darroch


The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.

The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672445#action_12672445 ] 

Benjamin Reed commented on ZOOKEEPER-309:
-----------------------------------------

+1 that's embarrassing! 

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.1
>            Reporter: Chris Darroch
>             Fix For: 3.1.0, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar reassigned ZOOKEEPER-309:
---------------------------------------

    Assignee: Mahadev konar

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681110#action_12681110 ] 

Mahadev konar commented on ZOOKEEPER-309:
-----------------------------------------

also forgot to mention that the tests fail with segmenetation fault without chris's patch and pass with the patch.. 

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-309:
------------------------------------

    Status: Patch Available  (was: Open)

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.1.0, 3.0.1, 3.0.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Darroch updated ZOOKEEPER-309:
------------------------------------

    Attachment: ZOOKEEPER-309.patch

Renamed patch file with issue key.

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681685#action_12681685 ] 

Hudson commented on ZOOKEEPER-309:
----------------------------------

Integrated in ZooKeeper-trunk #253 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/253/])
    

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Darroch updated ZOOKEEPER-309:
------------------------------------

        Fix Version/s: 3.2.0
                       3.1.0
    Affects Version/s: 3.0.1
               Status: Patch Available  (was: Open)

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.1
>            Reporter: Chris Darroch
>             Fix For: 3.1.0, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-309:
-----------------------------------

    Affects Version/s: 3.1.0
                       3.0.0
        Fix Version/s:     (was: 3.1.0)
                       3.1.1

Moving from 3.1 to 3.1.1 -- this is not a regression and has a workaround (too late in release cycle to address non-blocker for 3.1.0

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-309:
-----------------------------------

    Status: Open  (was: Patch Available)

Cancelling patch - needs tests. I suggest that tests be added for ACLs in general (not just this api) -- the cppunits are missing any kind of acl testing.

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.1, 3.0.0, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-309:
------------------------------------

    Attachment: ZOOKEEPER-309.patch

this patch adds some tests to chris's patch. The test runs the sync setacl's and getacl's and  since both of them use the async version of the set/get acl, it indirectly tests the async versions as well.

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Darroch updated ZOOKEEPER-309:
------------------------------------

    Attachment: zookeeper.c.patch

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.1
>            Reporter: Chris Darroch
>             Fix For: 3.1.0, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar reassigned ZOOKEEPER-309:
---------------------------------------

    Assignee: Mahadev konar

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Chris Darroch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Darroch updated ZOOKEEPER-309:
------------------------------------

    Attachment:     (was: zookeeper.c.patch)

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-309:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

+1, good to see we are testing acls now in c client. ;-)

Committed revision 752729.
Committed revision 752730.

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>            Assignee: Mahadev konar
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12672446#action_12672446 ] 

Mahadev konar commented on ZOOKEEPER-309:
-----------------------------------------

can we include a test case for this so that we do not get embarrased again? 

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.1
>            Reporter: Chris Darroch
>             Fix For: 3.1.0, 3.2.0
>
>         Attachments: zookeeper.c.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar reassigned ZOOKEEPER-309:
---------------------------------------

    Assignee:     (was: Mahadev konar)

> core dump using zoo_get_acl() 
> ------------------------------
>
>                 Key: ZOOKEEPER-309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.0.0, 3.0.1, 3.1.0
>            Reporter: Chris Darroch
>             Fix For: 3.1.1, 3.2.0
>
>         Attachments: ZOOKEEPER-309.patch
>
>
> The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request.  The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer.
> The attached patch removes this call.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.