You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2016/07/01 17:14:11 UTC

[jira] [Commented] (HBASE-15945) Patch for Key Value, Bytes and Cell

    [ https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359302#comment-15359302 ] 

Enis Soztutar commented on HBASE-15945:
---------------------------------------

Thanks [~sudeeps]. 

My only comment is the naming of CELL_TYPE, other than that, the patch looks good. It should be CellType: https://google.github.io/styleguide/cppguide.html#Enumerator_Names

> Patch for Key Value, Bytes and Cell
> -----------------------------------
>
>                 Key: HBASE-15945
>                 URL: https://issues.apache.org/jira/browse/HBASE-15945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-15945-HBASE-14850.v2.patch, HBASE-15945-HBASE-14850.v3.patch, HBASE-15945-HBASE-14850.v4.patch, HBASE-15945.HBASE-14850.v1.patch
>
>
> This patch contains an implementation of Key Value, Bytes and Cell modeled on the lines of Java implementation.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)