You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "James F. Adams (JIRA)" <ji...@apache.org> on 2007/12/02 05:13:43 UTC

[jira] Updated: (DERBY-3241) No syntax error when compiling statement with unterminated comment

     [ https://issues.apache.org/jira/browse/DERBY-3241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James F. Adams updated DERBY-3241:
----------------------------------

    Attachment: Derby-3241.diff

Attached a patch proposal (Derby-3241.diff) that I believe resolves this issue. 

The patch modifies sqlgrammar.jj to detect unterminated bracketed comments by correcting the use of SKIP and MORE regular expressions.  I also added some tests to CommentTest.java to check for unterminated bracketed comments.

> No syntax error when compiling statement with unterminated comment
> ------------------------------------------------------------------
>
>                 Key: DERBY-3241
>                 URL: https://issues.apache.org/jira/browse/DERBY-3241
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: James F. Adams
>            Priority: Minor
>         Attachments: Derby-3241.diff
>
>
> Compiling a statement with an unterminated comment doesn't raise a syntax error.
> ij> prepare p as 'values 1 /* unterminated comment ';
> ij> execute p;
> 1          
> -----------
> 1          
> 1 row selected

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.