You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/08/19 21:46:43 UTC

[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1225: Adding new attribute to control save the user groups origin

ahgittin commented on a change in pull request #1225:
URL: https://github.com/apache/brooklyn-server/pull/1225#discussion_r692508661



##########
File path: rest/rest-resources/src/main/java/org/apache/brooklyn/rest/security/provider/LdapSecurityProvider.java
##########
@@ -69,6 +70,7 @@
     public static final Logger LOG = LoggerFactory.getLogger(LdapSecurityProvider.class);
 
     public static final String LDAP_CONTEXT_FACTORY = "com.sun.jndi.ldap.LdapCtxFactory";
+    public static final String LDAP_USER_GROUPS_ORIGIN = "brooklyn.entitlements.user.groups.origin.LdapSecurityProvider";

Review comment:
       i'd make this be `LdapSecurityProvider.class.getName()` -- there is no need for origin in the value here (it is used as a value of a key which says `origin`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org