[GitHub] [spark] nchammas commented on a diff in pull request #40642: [SPARK-43010][PYTHON] Migrate Column errors into error class

["nchammas (via GitHub)" <gi...@apache.org>]

nchammas commented on code in PR #40642:
URL: https://github.com/apache/spark/pull/40642#discussion_r1328948048


##########
python/pyspark/errors/error_classes.py:
##########
@@ -24,6 +24,21 @@
       "Argument `<arg_name>` is required when <condition>."
     ]
   },
+  "CANNOT_ACCESS_TO_DUNDER": {

Review Comment:
   Not a big deal (and probably too late to change this since it's public), but I would have named this either `CANNOT_ACCESS_DUNDER` or `ILLEGAL_ACCESS_TO_DUNDER`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org