You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "emkornfield (via GitHub)" <gi...@apache.org> on 2026/03/27 20:45:45 UTC
Re: [PR] GH-43695: [C++][Parquet] flatbuffers metadata integration [arrow]
emkornfield commented on code in PR #48431:
URL: https://github.com/apache/arrow/pull/48431#discussion_r3003136177
##########
cpp/src/parquet/file_reader.cc:
##########
@@ -441,6 +442,35 @@ class SerializedFile : public ParquetFileReader::Contents {
auto footer_buffer,
source_->ReadAt(source_size_ - footer_read_size, footer_read_size));
uint32_t metadata_len = ParseFooterLength(footer_buffer, footer_read_size);
+ if (properties_.read_flatbuffer_metadata_if_present()) {
Review Comment:
nit: could we move most of this to a helper, this function is already getting kind of long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org