[GitHub] gianm commented on a change in pull request #6599: Optimization for expressions that hit a single long column.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #6599: Optimization for expressions that hit a single long column.
URL: https://github.com/apache/incubator-druid/pull/6599#discussion_r232515562
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/virtual/SingleLongInputCachingExpressionColumnValueSelector.java
 ##########
 @@ -155,4 +130,26 @@ public boolean isNull()
     // ExprEval.isNumericNull checks whether the parsed primitive value is null or not.
     return getObject().isNumericNull();
   }
+
+  public class LruEvalCache
+  {
+    private final Long2ObjectLinkedOpenHashMap<ExprEval> m = new Long2ObjectLinkedOpenHashMap<>(CACHE_SIZE);
 
 Review comment:
   Sounds like a good idea. I changed it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org