You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by st...@apache.org on 2022/05/26 03:18:37 UTC

[superset] branch master updated: fix(db): make to allow to show/hide the password when only creating (#20186)

This is an automated email from the ASF dual-hosted git repository.

stephenlyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 95b28fc134 fix(db): make to allow to show/hide the password when only creating (#20186)
95b28fc134 is described below

commit 95b28fc1346939017f8f6d867abeb12c7704d846
Author: smileydev <47...@users.noreply.github.com>
AuthorDate: Wed May 25 22:18:17 2022 -0500

    fix(db): make to allow to show/hide the password when only creating (#20186)
---
 .../database/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx
index a07c9c9498..34c21466be 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/CommonParameters.tsx
@@ -122,7 +122,7 @@ export const passwordField = ({
     id="password"
     name="password"
     required={required}
-    type={isEditMode && 'password'}
+    visibilityToggle={!isEditMode}
     value={db?.parameters?.password}
     validationMethods={{ onBlur: getValidation }}
     errorMessage={validationErrors?.password}