You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by milamberspace <gi...@git.apache.org> on 2017/01/06 20:18:03 UTC
[GitHub] cloudstack pull request #1896: [CLOUDSTACK-9732] Update L10N resource files ...
GitHub user milamberspace opened a pull request:
https://github.com/apache/cloudstack/pull/1896
[CLOUDSTACK-9732] Update L10N resource files with 4.9 strings from Transifex (20170106)
(PR with 4.9 branch)
Related to: http://markmail.org/message/lywieba2nxlrbyzf?q=list:org.apache.incubator.cloudstack-*+[VOTE]+Apache+Cloudstack+4.9.2.0+%28RC2%29
And update the others language too
cc @rhtyd @rafaelweingartner
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/milamberspace/cloudstack L10N-update-4.9-20170106
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1896
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
LGTM, only text/translation changes. Thanks @milamberspace
Travis test LGTM, trillian smoke tests are not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@karuturi pure translation changes, we need one more LGTM, otherwise this is ready for merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
Got it, thanks for the explanation. I saw that, and I was wondering if it could have been a bug or something else.
LGTM then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@milamberspace @rhtyd do you know why the entry "label.host.alerts" was removed from some languages?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1896: [CLOUDSTACK-9732] Update L10N resource files ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@milamberspace Should the merge to master be an empty merge? Meaning is this only for 4.9??
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1896
LGTM. @karuturi let's merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@karuturi Since master (4.10) use now JSON files for the localization files (and too because on Transifex the localization's resources for each version of CS are different), so this PR will be merge only on 4.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@rhtyd missed this one. Thanks for reminding. merging now.
@milamberspace Thanks for keeping the translations updated for every release :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on the issue:
https://github.com/apache/cloudstack/pull/1896
@rafaelweingartner It was because the source string (en) has been chenged by this PR 1803, so the translations have been deleted by Transifex to invite the translator to make the new translation.
https://github.com/apache/cloudstack/pull/1803/files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---