You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "gufengwyx8 (via GitHub)" <gi...@apache.org> on 2025/04/24 08:55:48 UTC
[PR] Optimize Oracle support subquery with alias. (#34667) [shardingsphere]
gufengwyx8 opened a new pull request, #35239:
URL: https://github.com/apache/shardingsphere/pull/35239
Fixes #34667.
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "gufengwyx8 (via GitHub)" <gi...@apache.org>.
gufengwyx8 commented on PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239#issuecomment-2827731974
@strongduanmu please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "gufengwyx8 (via GitHub)" <gi...@apache.org>.
gufengwyx8 commented on PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239#issuecomment-2983295409
any one can review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "gufengwyx8 (via GitHub)" <gi...@apache.org>.
gufengwyx8 commented on PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239#issuecomment-3153356310
> Hi @gufengwyx8 can you update release note?
Sure, I just update RELEASE-NOTES.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239#issuecomment-3182839142
Hi @gufengwyx8, can you comment on the original issue? I will assign it to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239#discussion_r2272167663
##########
RELEASE-NOTES.md:
##########
@@ -136,12 +136,16 @@
1. Kernel: Fix not return generate key when id set null - [35783](https://github.com/apache/shardingsphere/pull/35783)
1. SQL Parser: Fix set OnDuplicateKeyColumnsSegment on PostgreSQLInsertStatement - [#34425](https://github.com/apache/shardingsphere/pull/34425)
1. SQL Parser: Fix mysql sql parser error when sql contains implicit concat expression - [#34660](https://github.com/apache/shardingsphere/pull/34660)
+1. SQL Parser: Fix oralce sql parser error when sql contains subquery with alias - [#34667](https://github.com/apache/shardingsphere/issues/34667)
1. SQL Parser: Refactor pivot and unpivot clause handling to support multiple column names - [35586](https://github.com/apache/shardingsphere/pull/35586)
1. SQL Binder: Fix is unable to find the outer table in the NotExpressionBinder - [36135](https://github.com/apache/shardingsphere/pull/36135)
-1. Transaction: Fix conflicting dependencies of BASE transaction integration module - [#35142](https://github.com/apache/shardingsphere/pull/35142)
1. SQL Federation: Fix Operation not allowed after ResultSet closed exception when use sql federation - [#35206](https://github.com/apache/shardingsphere/pull/35206)
+1. Transaction: Fix conflicting dependencies of BASE transaction integration module - [#35142](https://github.com/apache/shardingsphere/pull/35142)
Review Comment:
Can you revert other release note change?
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DMLStatement.g4:
##########
@@ -471,6 +471,7 @@ queryTableExpr
: queryTableExprSampleClause
| queryName
| lateralClause
+ | lateralClause (AS? alias)?
Review Comment:
Maybe you can merge `lateralClause` and `lateralClause (AS? alias)?` to `lateralClause (AS? alias)?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Optimize Oracle support subquery with alias. [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #35239:
URL: https://github.com/apache/shardingsphere/pull/35239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org