You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/28 12:01:33 UTC
[GitHub] [shardingsphere] misselvexu opened a new pull request, #17177: Update outdated examples under examples/docker
misselvexu opened a new pull request, #17177:
URL: https://github.com/apache/shardingsphere/pull/17177
Fixes #17143 .
Changes proposed in this pull request:
- Update outdated examples under examples/docker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #17177: Update outdated examples under examples/docker
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17177:
URL: https://github.com/apache/shardingsphere/pull/17177#issuecomment-1112464403
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17177](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1360b95) into [master](https://codecov.io/gh/apache/shardingsphere/commit/27fa20080425c21673c5e5871027250867697576?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27fa200) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17177 +/- ##
============================================
+ Coverage 60.30% 60.35% +0.04%
Complexity 2116 2116
============================================
Files 3478 3493 +15
Lines 52083 52253 +170
Branches 8878 8896 +18
============================================
+ Hits 31410 31538 +128
- Misses 18038 18071 +33
- Partials 2635 2644 +9
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../common/statement/ddl/CreateFunctionStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvQ3JlYXRlRnVuY3Rpb25TdGF0ZW1lbnQuamF2YQ==) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...common/statement/ddl/CreateProcedureStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3N0YXRlbWVudC9kZGwvQ3JlYXRlUHJvY2VkdXJlU3RhdGVtZW50LmphdmE=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...est/column/value/impl/MySQLUnsignedIntHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRJbnRIYW5kbGVyLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...column/value/impl/MySQLUnsignedTinyintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRUaW55aW50SGFuZGxlci5qYXZh) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...olumn/value/impl/MySQLUnsignedSmallintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRTbWFsbGludEhhbmRsZXIuamF2YQ==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [...lumn/value/impl/MySQLUnsignedMediumintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRNZWRpdW1pbnRIYW5kbGVyLmphdmE=) | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
| [.../column/value/impl/MySQLUnsignedBigintHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1kaWFsZWN0L3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvbXlzcWwvaW5nZXN0L2NvbHVtbi92YWx1ZS9pbXBsL015U1FMVW5zaWduZWRCaWdpbnRIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-28.58%)` | :arrow_down: |
| [...eadwritesplitting/rule/ReadwriteSplittingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9ydWxlL1JlYWR3cml0ZVNwbGl0dGluZ1J1bGUuamF2YQ==) | `47.22% <0.00%> (-13.80%)` | :arrow_down: |
| [...istry/metadata/watcher/MetaDataChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9tZXRhZGF0YS93YXRjaGVyL01ldGFEYXRhQ2hhbmdlZFdhdGNoZXIuamF2YQ==) | `67.79% <0.00%> (-11.80%)` | :arrow_down: |
| [...litting/rule/ReadwriteSplittingDataSourceRule.java](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9ydWxlL1JlYWR3cml0ZVNwbGl0dGluZ0RhdGFTb3VyY2VSdWxlLmphdmE=) | `84.61% <0.00%> (-7.70%)` | :arrow_down: |
| ... and [171 more](https://codecov.io/gh/apache/shardingsphere/pull/17177/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27fa200...1360b95](https://codecov.io/gh/apache/shardingsphere/pull/17177?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #17177: Update outdated examples under examples/docker
Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #17177:
URL: https://github.com/apache/shardingsphere/pull/17177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #17177: Update outdated examples under examples/docker
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on PR #17177:
URL: https://github.com/apache/shardingsphere/pull/17177#issuecomment-1120730279
@misselvexu Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #17177: Update outdated examples under examples/docker
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #17177:
URL: https://github.com/apache/shardingsphere/pull/17177#discussion_r867659939
##########
examples/docker/shardingsphere-proxy/sharding/docker-compose.yml:
##########
@@ -17,40 +17,40 @@
version: '3'
services:
- mysql:
- ## for different MySQL version, you could get more at here : https://hub.docker.com/_/mysql?tab=tags
- image: "mysql:5.7"
- ## port binding to 3306, you could change to 13306:3306 or any other available port you want
+ postgres:
+ ## for different postgres version, you could get more at here : https://hub.docker.com/_/postgres?tab=tags
+ image: "postgres:latest"
+ ## port binding to 5432, you could change to 15432:5432 or any other available port you want
ports:
- - "3306:3306"
- container_name: shardingsphere-example-mysql
- ## launch MySQL without password
- ## you could access MySQL like `mysql -h127.0.0.1 -P3306 -uroot`
- ## if you insist to access MySQL with password, remove `MYSQL_ALLOW_EMPTY_PASSWORD=yes` and then use MYSQL_ROOT_PASSWORD argument
- # - MYSQL_ROOT_PASSWORD=root
+ - "5432:5432"
+ container_name: shardingsphere-example-postgres
+ ## launch Postgres without password
+ ## you could access Postgres like `psql -d your_database_name -h 127.0.0.1 -U root -p 5432 -W`
environment:
- - MYSQL_ALLOW_EMPTY_PASSWORD=yes
- ## copy the manual_schema.sql to /docker-entrypoint-initdb.d/ . this will init the sql file when the MySQL in container start up
+ - TZ=Asia/Shanghai
+ - POSTGRES_USER=postgres
+ - POSTGRES_PASSWORD=postgres
+ ## copy the manual_schema.sql to /docker-entrypoint-initdb.d/ . this will init the sql file when the Postgres in container start up
volumes:
- ../../../src/resources/manual_schema.sql:/docker-entrypoint-initdb.d/manual_schema.sql
proxy:
## get more versions of proxy here : https://hub.docker.com/r/apache/sharding-proxy/tags
- image: "apache/sharding-proxy:4.1.1"
+ image: "apache/sharding-proxy:latest"
Review Comment:
The image should be `apache/shardingsphere-proxy`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] misselvexu commented on a diff in pull request #17177: Update outdated examples under examples/docker
Posted by GitBox <gi...@apache.org>.
misselvexu commented on code in PR #17177:
URL: https://github.com/apache/shardingsphere/pull/17177#discussion_r867664971
##########
examples/docker/shardingsphere-proxy/sharding/docker-compose.yml:
##########
@@ -17,40 +17,40 @@
version: '3'
services:
- mysql:
- ## for different MySQL version, you could get more at here : https://hub.docker.com/_/mysql?tab=tags
- image: "mysql:5.7"
- ## port binding to 3306, you could change to 13306:3306 or any other available port you want
+ postgres:
+ ## for different postgres version, you could get more at here : https://hub.docker.com/_/postgres?tab=tags
+ image: "postgres:latest"
+ ## port binding to 5432, you could change to 15432:5432 or any other available port you want
ports:
- - "3306:3306"
- container_name: shardingsphere-example-mysql
- ## launch MySQL without password
- ## you could access MySQL like `mysql -h127.0.0.1 -P3306 -uroot`
- ## if you insist to access MySQL with password, remove `MYSQL_ALLOW_EMPTY_PASSWORD=yes` and then use MYSQL_ROOT_PASSWORD argument
- # - MYSQL_ROOT_PASSWORD=root
+ - "5432:5432"
+ container_name: shardingsphere-example-postgres
+ ## launch Postgres without password
+ ## you could access Postgres like `psql -d your_database_name -h 127.0.0.1 -U root -p 5432 -W`
environment:
- - MYSQL_ALLOW_EMPTY_PASSWORD=yes
- ## copy the manual_schema.sql to /docker-entrypoint-initdb.d/ . this will init the sql file when the MySQL in container start up
+ - TZ=Asia/Shanghai
+ - POSTGRES_USER=postgres
+ - POSTGRES_PASSWORD=postgres
+ ## copy the manual_schema.sql to /docker-entrypoint-initdb.d/ . this will init the sql file when the Postgres in container start up
volumes:
- ../../../src/resources/manual_schema.sql:/docker-entrypoint-initdb.d/manual_schema.sql
proxy:
## get more versions of proxy here : https://hub.docker.com/r/apache/sharding-proxy/tags
- image: "apache/sharding-proxy:4.1.1"
+ image: "apache/sharding-proxy:latest"
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org