You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by Alexander Saydakov <sa...@yahooinc.com.INVALID> on 2023/04/26 18:37:52 UTC
[VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Hello Apache DataSketches PMC and Community,
This is a call for vote to release Apache DataSketches-cpp candidate
version 4.1.0-rc1
Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
- HLL union speed improvement
- Fixed a bug in theta and tuple union base
- new density sketch
- new count min sketch
- thread local random generator
- generic quantile sketches in Python (KLL, REQ, classic quantiles)
- generic frequent items sketch in Python
- generic tuple sketch in Python
- added optional compression of serialized theta sketch
- iterators use new style (no inheritance from std::iterator)
Source repository:
- https://github.com/apache/datasketches-cpp
Git Tag for this release:
- https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on
branch 4.1.x
Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
The Release Candidate / Zip Repository, including convenience binaries (in
pypi subdirectory):
- https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
The public signing key can be found in the KEYS file:
- https://dist.apache.org/repos/dist/dev/datasketches/KEYS
<https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
The artifacts have been signed with key:
68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
alsay@apache.org>
Build & Test Guide (C++):
- https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
Build & Test Guide (Python):
- https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
The vote will be performed as follows:
- This letter will be published on dev@ and remain open for at least 72
hours (excluding weekends and holidays), AND until at least 3 (+1) PMC votes or
a majority of (+1) PMC votes are acquired. Anyone in the community can vote.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you,
Alexander Saydakov
alsay@apache.org
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by Alexander Saydakov <sa...@yahooinc.com.INVALID>.
There has been plenty of time for everyone to cast a vote. We have 3
positive binding votes and 2 positive non-binding votes.
Please consider this vote closed.
Thank you very much.
On Wed, May 3, 2023 at 8:03 AM David Cromberge <dc...@apache.org>
wrote:
> +1
>
> Checked (on OS X Ventura 13.0.1)
>
> - Verify checksum and shasum signatures for cpp distribution
> - Built cpp and run tests
> - Make and install local package using cmake
> - Built python and run tests using tox
> - Checked README, NOTICE and LICENSE
> - licence headers on new density sketch sources / tests
>
> Well done to the team for all the improvements / enhancements in this
> release,
> David
>
> On 2023/04/28 22:21:52 Lee Rhodes wrote:
> > +1
> > The whole process ran very smoothly.
> >
> > My checks (macOS Ventura 13.3.1)
> >
> > - Verify shasum and signature for source release
> > - cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
> > - cmake --build build/Release -t all test
> > - python3 -m pip install .
> > - tox
> >
> > Two minor issues:
> >
> > - The Python README.md doesn't include the new Tuple Sketch in the
> list
> > of available sketches.
> > - The copyright year needs to be updated to 2023 in NOTICE (Will
> already
> > mentioned this as well)
> >
> > Lee.
> >
> >
> > On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov
> > <sa...@yahooinc.com.invalid> wrote:
> >
> > > Hello Apache DataSketches PMC and Community,
> > >
> > >
> > > This is a call for vote to release Apache DataSketches-cpp candidate
> > > version 4.1.0-rc1
> > >
> > >
> > > Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
> > >
> > > - HLL union speed improvement
> > >
> > > - Fixed a bug in theta and tuple union base
> > >
> > > - new density sketch
> > >
> > > - new count min sketch
> > >
> > > - thread local random generator
> > >
> > > - generic quantile sketches in Python (KLL, REQ, classic quantiles)
> > >
> > > - generic frequent items sketch in Python
> > >
> > > - generic tuple sketch in Python
> > >
> > > - added optional compression of serialized theta sketch
> > >
> > > - iterators use new style (no inheritance from std::iterator)
> > >
> > >
> > > Source repository:
> > >
> > > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSupQp41FFw$
> > >
> > >
> > > Git Tag for this release:
> > >
> > > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSurpm3uTiw$
> on
> > > branch 4.1.x
> > >
> > >
> > > Git HashId for this release is:
> c3abaaefe5fa400eed99e082af07c1b61a7144db
> > >
> > >
> > > The Release Candidate / Zip Repository, including convenience binaries
> (in
> > > pypi subdirectory):
> > >
> > > -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSuqTPHcxGw$
> > >
> > >
> > > The public signing key can be found in the KEYS file:
> > >
> > > -
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSuo7iKJpig$
> > > <
> https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$
> >
> > >
> > >
> > >
> > > The artifacts have been signed with key:
> > >
> > > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY)
> <
> > > alsay@apache.org>
> > >
> > >
> > > Build & Test Guide (C++):
> > >
> > > -
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSuofJYzueg$
> > >
> > >
> > > Build & Test Guide (Python):
> > >
> > > -
> > >
> https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md__;!!Op6eflyXZCqGR5I!FoHoDqEFWTGImY39lW-RBYsUpWX1saeBthK8CYjq_ZfeaV1HCIyYYRy-e9vQ7K_vjhDSQoFEUYBYSuo0Ut5rmA$
> > >
> > >
> > > The vote will be performed as follows:
> > >
> > > - This letter will be published on dev@ and remain open for at
> least
> > > 72 hours (excluding weekends and holidays), AND until at least 3 (+1)
> PMC
> > > votes or a majority of (+1) PMC votes are acquired. Anyone in the
> > > community can vote.
> > >
> > >
> > > Please vote accordingly:
> > >
> > >
> > > [ ] +1 approve
> > >
> > > [ ] +0 no opinion
> > >
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Thank you,
> > >
> > > Alexander Saydakov
> > >
> > > alsay@apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
> For additional commands, e-mail: dev-help@datasketches.apache.org
>
>
Re: [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by David Cromberge <dc...@apache.org>.
+1
Checked (on OS X Ventura 13.0.1)
- Verify checksum and shasum signatures for cpp distribution
- Built cpp and run tests
- Make and install local package using cmake
- Built python and run tests using tox
- Checked README, NOTICE and LICENSE
- licence headers on new density sketch sources / tests
Well done to the team for all the improvements / enhancements in this release,
David
On 2023/04/28 22:21:52 Lee Rhodes wrote:
> +1
> The whole process ran very smoothly.
>
> My checks (macOS Ventura 13.3.1)
>
> - Verify shasum and signature for source release
> - cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
> - cmake --build build/Release -t all test
> - python3 -m pip install .
> - tox
>
> Two minor issues:
>
> - The Python README.md doesn't include the new Tuple Sketch in the list
> of available sketches.
> - The copyright year needs to be updated to 2023 in NOTICE (Will already
> mentioned this as well)
>
> Lee.
>
>
> On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
> > Hello Apache DataSketches PMC and Community,
> >
> >
> > This is a call for vote to release Apache DataSketches-cpp candidate
> > version 4.1.0-rc1
> >
> >
> > Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
> >
> > - HLL union speed improvement
> >
> > - Fixed a bug in theta and tuple union base
> >
> > - new density sketch
> >
> > - new count min sketch
> >
> > - thread local random generator
> >
> > - generic quantile sketches in Python (KLL, REQ, classic quantiles)
> >
> > - generic frequent items sketch in Python
> >
> > - generic tuple sketch in Python
> >
> > - added optional compression of serialized theta sketch
> >
> > - iterators use new style (no inheritance from std::iterator)
> >
> >
> > Source repository:
> >
> > - https://github.com/apache/datasketches-cpp
> >
> >
> > Git Tag for this release:
> >
> > - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on
> > branch 4.1.x
> >
> >
> > Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
> >
> >
> > The Release Candidate / Zip Repository, including convenience binaries (in
> > pypi subdirectory):
> >
> > - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
> >
> >
> > The public signing key can be found in the KEYS file:
> >
> > - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> > <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
> >
> >
> >
> > The artifacts have been signed with key:
> >
> > 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> > alsay@apache.org>
> >
> >
> > Build & Test Guide (C++):
> >
> > - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
> >
> >
> > Build & Test Guide (Python):
> >
> > -
> > https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
> >
> >
> > The vote will be performed as follows:
> >
> > - This letter will be published on dev@ and remain open for at least
> > 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> > votes or a majority of (+1) PMC votes are acquired. Anyone in the
> > community can vote.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> >
> > Thank you,
> >
> > Alexander Saydakov
> >
> > alsay@apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by Lee Rhodes <le...@gmail.com>.
+1
The whole process ran very smoothly.
My checks (macOS Ventura 13.3.1)
- Verify shasum and signature for source release
- cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
- cmake --build build/Release -t all test
- python3 -m pip install .
- tox
Two minor issues:
- The Python README.md doesn't include the new Tuple Sketch in the list
of available sketches.
- The copyright year needs to be updated to 2023 in NOTICE (Will already
mentioned this as well)
Lee.
On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Hello Apache DataSketches PMC and Community,
>
>
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 4.1.0-rc1
>
>
> Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
>
> - HLL union speed improvement
>
> - Fixed a bug in theta and tuple union base
>
> - new density sketch
>
> - new count min sketch
>
> - thread local random generator
>
> - generic quantile sketches in Python (KLL, REQ, classic quantiles)
>
> - generic frequent items sketch in Python
>
> - generic tuple sketch in Python
>
> - added optional compression of serialized theta sketch
>
> - iterators use new style (no inheritance from std::iterator)
>
>
> Source repository:
>
> - https://github.com/apache/datasketches-cpp
>
>
> Git Tag for this release:
>
> - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on
> branch 4.1.x
>
>
> Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
>
>
> The Release Candidate / Zip Repository, including convenience binaries (in
> pypi subdirectory):
>
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
>
>
> The public signing key can be found in the KEYS file:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>
>
>
> The artifacts have been signed with key:
>
> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
>
>
> Build & Test Guide (C++):
>
> - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
>
>
> Build & Test Guide (Python):
>
> -
> https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
>
>
> The vote will be performed as follows:
>
> - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thank you,
>
> Alexander Saydakov
>
> alsay@apache.org
>
>
Re: [E] [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by Will Lauer <wl...@yahooinc.com.INVALID>.
+1
My checks (on windows 10 w/ VS 2019):
- Verify shasum and signature for source release
- build ( cmake -S . -B build\Release && cmake --build build\Release )
- run unit tests ( cmake --build build\Release --target RUN_TESTS )
- build python (python 3.8, python -m pip install . )
- python unit tests ( tox )
Two minor issues I noticed:
1. I think the copyright year needs to be updated in NOTICE
2. the source archive doesn't extract on Windows using the default OS
tools (explorer). It results in an empty directory. Using other tools, like
7zip, to extract the archive works fine.
Will
Will Lauer
Senior Principal Architect, Audience & Advertising Reporting
Data Platforms & Systems Engineering
M 508 561 6427
Champaign Office
1908 S. First St
Champaign, IL 61822
On Wed, Apr 26, 2023 at 1:38 PM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Hello Apache DataSketches PMC and Community,
>
>
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 4.1.0-rc1
>
>
> Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
>
> - HLL union speed improvement
>
> - Fixed a bug in theta and tuple union base
>
> - new density sketch
>
> - new count min sketch
>
> - thread local random generator
>
> - generic quantile sketches in Python (KLL, REQ, classic quantiles)
>
> - generic frequent items sketch in Python
>
> - generic tuple sketch in Python
>
> - added optional compression of serialized theta sketch
>
> - iterators use new style (no inheritance from std::iterator)
>
>
> Source repository:
>
> - https://github.com/apache/datasketches-cpp
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_xhqq55x$>
>
>
> Git Tag for this release:
>
> - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_wTqTGHz$> on
> branch 4.1.x
>
>
> Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
>
>
> The Release Candidate / Zip Repository, including convenience binaries (in
> pypi subdirectory):
>
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_4NPcU12$>
>
>
> The public signing key can be found in the KEYS file:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>
>
>
> The artifacts have been signed with key:
>
> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
>
>
> Build & Test Guide (C++):
>
> - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_7jP2PtX$>
>
>
> Build & Test Guide (Python):
>
> -
> https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md__;!!Op6eflyXZCqGR5I!HQ3GyUUXdsvxFLsAiVIsBUbCj0udV_QbPVuQwyrJvi3EMwS1FHTCPDeRFF4y4AwxA2WuuCopfeZXbr95V7b3_3B4Ll-h$>
>
>
> The vote will be performed as follows:
>
> - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thank you,
>
> Alexander Saydakov
>
> alsay@apache.org
>
>
Re: [E] Re: [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by Charlie Dickens <ch...@yahooinc.com.INVALID>.
+1
✅ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release; cmake --build
build/Release -t all test
✅ cmake -B build -S . -DCMAKE_BUILD_TYPE=Release -DWITH_PYTHON=1 (in venv
with pybind11-global)
✅ tox
✅ installed python 3.9 wheels and ran unit tests.
On Thu, 27 Apr 2023 at 06:41, Jon Malkin <jo...@gmail.com> wrote:
> +1 (binding)
>
> My checks:
> * Verify shasum and signature for all files, including pypi directory
> * cmake -B build -S . -DCMAKE_BUILD_TYPE=Release -DWITH_PYTHON=1 (after
> creating a venv and installing pybind11-global)
> * cmake --build build -t all test
> * tox
> * Installed the relevant pypi file for my desktop and ran all the python
> tests directly
> * Verified that all new files have appropriate license header
>
> jon
>
>
> On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov
> <sa...@yahooinc.com.invalid> wrote:
>
>> Hello Apache DataSketches PMC and Community,
>>
>>
>> This is a call for vote to release Apache DataSketches-cpp candidate
>> version 4.1.0-rc1
>>
>>
>> Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
>>
>> - HLL union speed improvement
>>
>> - Fixed a bug in theta and tuple union base
>>
>> - new density sketch
>>
>> - new count min sketch
>>
>> - thread local random generator
>>
>> - generic quantile sketches in Python (KLL, REQ, classic quantiles)
>>
>> - generic frequent items sketch in Python
>>
>> - generic tuple sketch in Python
>>
>> - added optional compression of serialized theta sketch
>>
>> - iterators use new style (no inheritance from std::iterator)
>>
>>
>> Source repository:
>>
>> - https://github.com/apache/datasketches-cpp
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!CNono8mkvjEdthcVvmrWLztp7iGte5nsA6-SQIvj45iwLmvWLP2aSMt2HNva8UBZpuUkXV-DZkxmXeI5ed8LqURCs2Cp$>
>>
>>
>> Git Tag for this release:
>>
>> - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1__;!!Op6eflyXZCqGR5I!CNono8mkvjEdthcVvmrWLztp7iGte5nsA6-SQIvj45iwLmvWLP2aSMt2HNva8UBZpuUkXV-DZkxmXeI5ed8LqZbCdShY$> on
>> branch 4.1.x
>>
>>
>> Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
>>
>>
>> The Release Candidate / Zip Repository, including convenience binaries
>> (in pypi subdirectory):
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/__;!!Op6eflyXZCqGR5I!CNono8mkvjEdthcVvmrWLztp7iGte5nsA6-SQIvj45iwLmvWLP2aSMt2HNva8UBZpuUkXV-DZkxmXeI5ed8LqSf-H4sR$>
>>
>>
>> The public signing key can be found in the KEYS file:
>>
>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>>
>>
>>
>> The artifacts have been signed with key:
>>
>> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
>> alsay@apache.org>
>>
>>
>> Build & Test Guide (C++):
>>
>> - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md__;!!Op6eflyXZCqGR5I!CNono8mkvjEdthcVvmrWLztp7iGte5nsA6-SQIvj45iwLmvWLP2aSMt2HNva8UBZpuUkXV-DZkxmXeI5ed8LqUSToWpi$>
>>
>>
>> Build & Test Guide (Python):
>>
>> -
>> https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md__;!!Op6eflyXZCqGR5I!CNono8mkvjEdthcVvmrWLztp7iGte5nsA6-SQIvj45iwLmvWLP2aSMt2HNva8UBZpuUkXV-DZkxmXeI5ed8LqawqXO4T$>
>>
>>
>> The vote will be performed as follows:
>>
>> - This letter will be published on dev@ and remain open for at least
>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
>> votes or a majority of (+1) PMC votes are acquired. Anyone in the
>> community can vote.
>>
>>
>> Please vote accordingly:
>>
>>
>> [ ] +1 approve
>>
>> [ ] +0 no opinion
>>
>> [ ] -1 disapprove with the reason
>>
>>
>> Thank you,
>>
>> Alexander Saydakov
>>
>> alsay@apache.org
>>
>>
Re: [VOTE] Release Apache DataSketches-cpp 4.1.0-rc1
Posted by Jon Malkin <jo...@gmail.com>.
+1 (binding)
My checks:
* Verify shasum and signature for all files, including pypi directory
* cmake -B build -S . -DCMAKE_BUILD_TYPE=Release -DWITH_PYTHON=1 (after
creating a venv and installing pybind11-global)
* cmake --build build -t all test
* tox
* Installed the relevant pypi file for my desktop and ran all the python
tests directly
* Verified that all new files have appropriate license header
jon
On Wed, Apr 26, 2023 at 11:38 AM Alexander Saydakov
<sa...@yahooinc.com.invalid> wrote:
> Hello Apache DataSketches PMC and Community,
>
>
> This is a call for vote to release Apache DataSketches-cpp candidate
> version 4.1.0-rc1
>
>
> Changes since datasketches-cpp 4.0.0 release (5 Dec 2022):
>
> - HLL union speed improvement
>
> - Fixed a bug in theta and tuple union base
>
> - new density sketch
>
> - new count min sketch
>
> - thread local random generator
>
> - generic quantile sketches in Python (KLL, REQ, classic quantiles)
>
> - generic frequent items sketch in Python
>
> - generic tuple sketch in Python
>
> - added optional compression of serialized theta sketch
>
> - iterators use new style (no inheritance from std::iterator)
>
>
> Source repository:
>
> - https://github.com/apache/datasketches-cpp
>
>
> Git Tag for this release:
>
> - https://github.com/apache/datasketches-cpp/releases/tag/4.1.0-rc1 on
> branch 4.1.x
>
>
> Git HashId for this release is: c3abaaefe5fa400eed99e082af07c1b61a7144db
>
>
> The Release Candidate / Zip Repository, including convenience binaries (in
> pypi subdirectory):
>
> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/4.1.0-rc1/
>
>
> The public signing key can be found in the KEYS file:
>
> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS
> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$>
>
>
>
> The artifacts have been signed with key:
>
> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) <
> alsay@apache.org>
>
>
> Build & Test Guide (C++):
>
> - https://github.com/apache/datasketches-cpp/blob/4.1.x/README.md
>
>
> Build & Test Guide (Python):
>
> -
> https://github.com/apache/datasketches-cpp/blob/4.1.x/python/README.md
>
>
> The vote will be performed as follows:
>
> - This letter will be published on dev@ and remain open for at least
> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) PMC
> votes or a majority of (+1) PMC votes are acquired. Anyone in the
> community can vote.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
>
> [ ] +0 no opinion
>
> [ ] -1 disapprove with the reason
>
>
> Thank you,
>
> Alexander Saydakov
>
> alsay@apache.org
>
>