You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2024/08/18 07:29:04 UTC

[PR] test: add Nacos mock test [incubator-seata]

slievrly opened a new pull request, #6763:
URL: https://github.com/apache/incubator-seata/pull/6763

   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   
   add Nacos mock test
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] optimize: optimize NacosConfiguration singleton reload [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #6763:
URL: https://github.com/apache/incubator-seata/pull/6763


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] optimize: optimize NacosConfiguration singleton reload [incubator-seata]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #6763:
URL: https://github.com/apache/incubator-seata/pull/6763#issuecomment-2295201141

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `59.09091%` with `9 lines` in your changes missing coverage. Please review.
   > Project coverage is 50.71%. Comparing base [(`f7c3866`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f7c38669dd4d1bc9943f44f1ee966b4197298799?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`8d67930`)](https://app.codecov.io/gh/apache/incubator-seata/commit/8d6793039a9db6e969a151244481d90aba510b41?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   | [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../apache/seata/config/nacos/NacosConfiguration.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?src=pr&el=tree&filepath=config%2Fseata-config-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2Fnacos%2FNacosConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29uZmlnL25hY29zL05hY29zQ29uZmlndXJhdGlvbi5qYXZh) | 59.09% | [2 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6763/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #6763      +/-   ##
   ============================================
   + Coverage     50.57%   50.71%   +0.13%     
   - Complexity     5936     5954      +18     
   ============================================
     Files          1061     1061              
     Lines         37123    37133      +10     
     Branches       4404     4407       +3     
   ============================================
   + Hits          18776    18831      +55     
   + Misses        16445    16381      -64     
   - Partials       1902     1921      +19     
   ```
   
   | [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../apache/seata/config/nacos/NacosConfiguration.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6763?src=pr&el=tree&filepath=config%2Fseata-config-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2Fnacos%2FNacosConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy1uYWNvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29uZmlnL25hY29zL05hY29zQ29uZmlndXJhdGlvbi5qYXZh) | `40.83% <59.09%> (+28.68%)` | :arrow_up: |
   
   ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6763/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org