You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/23 20:15:14 UTC
[GitHub] [kafka] cmccabe opened a new pull request #8539: MINOR: equals() should compare all fields for generated classes
cmccabe opened a new pull request #8539:
URL: https://github.com/apache/kafka/pull/8539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #8539: MINOR: equals() should compare all fields for generated classes
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #8539:
URL: https://github.com/apache/kafka/pull/8539#discussion_r414112419
##########
File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##########
@@ -2003,15 +2007,17 @@ private void generateStringToBytes(String name) {
buffer.printf("_cache.cacheSerializedValue(%s, _stringBytes);%n", name);
}
- private void generateClassEquals(String className, StructSpec struct, boolean onlyMapKeys) {
+ private void generateClassEquals(String className, StructSpec struct,
+ boolean elementKeysAreEqual) {
buffer.printf("@Override%n");
- buffer.printf("public boolean equals(Object obj) {%n");
+ buffer.printf("public boolean %s(Object obj) {%n",
+ elementKeysAreEqual ? "elementKeysAreEqual" : "equals");
buffer.incrementIndent();
buffer.printf("if (!(obj instanceof %s)) return false;%n", className);
if (!struct.fields().isEmpty()) {
buffer.printf("%s other = (%s) obj;%n", className, className);
for (FieldSpec field : struct.fields()) {
- if ((!onlyMapKeys) || field.mapKey()) {
+ if ((!elementKeysAreEqual) || field.mapKey()) {
Review comment:
nit: unneeded parenthesis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org