You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Amogh Margoor (Code Review)" <ge...@cloudera.org> on 2021/06/02 00:06:20 UTC
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Amogh Margoor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17530
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
11 files changed, 380 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/17530/1
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8864/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 3
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 23:36:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7211/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 4
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 16:21:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
12 files changed, 519 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/17530/3
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 3
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 6:
Verification had failed due to changes in error string. I have changed it and rerun the pre-review test here: https://jenkins.impala.io/job/pre-review-test/975/
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 6
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:36:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 7
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 15:46:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 3: Code-Review+2
Thank you for applying the changes! Looks great!
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 3
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 16:20:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
12 files changed, 521 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/17530/5
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 5
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 4
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 16:21:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8832/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 13:32:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8829/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 00:26:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
12 files changed, 521 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/17530/6
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 6
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17530/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/17530/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@714
PS5, Line 714: "Unsetting the 'kudu.table_name' table property is not supported for synchronized" +
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 5
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:10:30 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 2:
> (15 comments)
>
> The change looks great, I've mostly found nits.
Apologies for the indent issues. I think my intelliJ setup caused it.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Jun 2021 19:42:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7215/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 7
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:46:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@48
PS1, Line 48: public AlterTableUnSetTblProperties(TableName tableName, PartitionSet partitionSet, boolean ifExists,
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@49
PS1, Line 49: TTablePropertyType targetProperty, List<String> tblPropertyKeys) {
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3748
PS1, Line 3748: TAlterTableUnSetTblPropertiesParams params, Reference<Long> numUpdatedPartitions)
line too long (123 > 90)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@806
PS1, Line 806: "Property key length must be <= " + MetaStoreUtil.MAX_PROPERTY_KEY_LENGTH + ": "
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@821
PS1, Line 821: "Property key length must be <= " + MetaStoreUtil.MAX_PROPERTY_KEY_LENGTH + ": "
line too long (94 > 90)
http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@836
PS1, Line 836: "Changing the 'storage_handler' table property is not supported to protect " +
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Jun 2021 00:07:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7211/
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 4
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Jun 2021 22:20:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 2:
(15 comments)
The change looks great, I've mostly found nits.
http://gerrit.cloudera.org:8080/#/c/17530/2/common/thrift/JniCatalog.thrift
File common/thrift/JniCatalog.thrift:
http://gerrit.cloudera.org:8080/#/c/17530/2/common/thrift/JniCatalog.thrift@391
PS2, Line 391: ('k1', 'k2'...)
nit: ('k1'='a', 'k2'='b'...)
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@63
PS2, Line 63:
nit: +1 indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@116
PS2, Line 116: if (KuduTable.isSynchronizedTable(table_.getMetaStoreTable())) {
: AnalysisUtils.throwIfTrue(tblPropertyKeys_.contains(KuduTable.KEY_TABLE_NAME),
: String.format("Not allowed to unset '%s' for synchronized Kudu tables .",
: KuduTable.KEY_TABLE_NAME));
nit: Can we use the following instead?
propertyCheck(KuduTable.KEY_TABLE_NAME, "synchronized Kudu");
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@121
PS2, Line 121: List<String> unsupportedKuduProperties = Lists.newArrayList(KuduTable.KEY_TABLE_ID,
: KuduTable.KEY_MASTER_HOSTS);
: for (String unsupportedProperty: unsupportedKuduProperties) {
: // Throw error if unsupportedProperty is provided.
: AnalysisUtils.throwIfTrue(tblPropertyKeys_.contains(unsupportedProperty),
: String.format("Property '%s' cannot be unset for Kudu tables",
: unsupportedProperty));
: }
nit: can we use the following instead?
propertyCheck(KuduTable.KEY_TABLE_ID, "Kudu");
propertyCheck(KuduTable.KEY_MASTER_HOSTS, "Kudu");
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@873
PS2, Line 873:
nit: too much indentation
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@877
PS2, Line 877:
nit: too much indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@871
PS2, Line 871: case UNSET_TBL_PROPERTIES:
: alterTableUnSetTblProperties(tbl, params.getUnset_tbl_properties_params(),
: numUpdatedPartitions);
: reloadTableSchema = true;
: if (params.getUnset_tbl_properties_params().isSetPartition_set()) {
: addSummary(response,
: "Updated " + numUpdatedPartitions.getRef() + " partition(s).");
: } else {
: addSummary(response, "Updated table.");
: }
nit: I think this could be moved to just after SET_TBL_PROPERTIES
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3790
PS2, Line 3790:
nit: too much indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3801
PS2, Line 3801: "
nit: too much indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3818
PS2, Line 3818: removeProperties.removeAll(keys);
This modifies 'TAlterTableUnSetTblPropertiesParams params' which might cause strange behavior later.
Since we are on an error path here, I think we could just have a copy of removeProperties and modify that.
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1162
PS2, Line 1162:
nit: too much indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1166
PS2, Line 1166:
nit: too much indent
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java:
http://gerrit.cloudera.org:8080/#/c/17530/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@687
PS2, Line 687: // Unsetting kudu.table_id is not allowed for Kudu tables.
: AnalysisError("ALTER TABLE functional_kudu.testtbl UNSET " +
: "TBLPROPERTIES ('kudu.table_id')",
: "Property 'kudu.table_id' cannot be unset for Kudu tables");
:
: // Unsetting kudu.master_addresses is not allowed for Kudu tables.
: AnalysisError("ALTER TABLE functional_kudu.testtbl UNSET " +
: "TBLPROPERTIES ('kudu.master_addresses')",
: "Property 'kudu.master_addresses' cannot be unset for Kudu tables");
Indentation is a bit messy
http://gerrit.cloudera.org:8080/#/c/17530/2/testdata/workloads/functional-query/queries/QueryTest/alter-table.test
File testdata/workloads/functional-query/queries/QueryTest/alter-table.test:
http://gerrit.cloudera.org:8080/#/c/17530/2/testdata/workloads/functional-query/queries/QueryTest/alter-table.test@1824
PS2, Line 1824: functional_avro.alltypes
Tables in the functional dataset are used by other tests as well, maybe even in parallel. So it is better if we not modify them, only their copy, or create an external table that points to them and change the table property of the external table.
http://gerrit.cloudera.org:8080/#/c/17530/2/testdata/workloads/functional-query/queries/QueryTest/alter-table.test@1845
PS2, Line 1845: ====
Could you please add a few tests where you are unsetting multiple properties?
E.g.:
* all props exist
* some exist, some not
* with and without 'if exists'
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Jun 2021 16:58:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 7
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:46:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8879/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 6
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:35:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Reviewed-on: http://gerrit.cloudera.org:8080/17530
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
12 files changed, 521 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 8
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Amogh Margoor (Code Review)" <ge...@cloudera.org>.
Amogh Margoor has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
This patch adds ability to unset or delete table properties or serde
properties for a table. It supports 'IF EXISTS' clause in case users
are not sure if property being unset exists. Without 'IF EXISTS',
trying to unset property that doesn't exist will fail.
Tests:
1. Added Unit tests and end-to-end tests
2. Covered tables of different storage type like Kudu,
Iceberg, HDFS table.
Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
---
M common/thrift/JniCatalog.thrift
M fe/src/main/cup/sql-parser.cup
A fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
M fe/src/main/java/org/apache/impala/analysis/AnalysisUtils.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java
M testdata/workloads/functional-query/queries/QueryTest/alter-table.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
M testdata/workloads/functional-query/queries/QueryTest/kudu_alter.test
12 files changed, 448 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/17530/2
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 2
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8878/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 5
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:31:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17530 )
Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET TBLPROPERTIES/SERDEPROPERTIES
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 6
Gerrit-Owner: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Jun 2021 09:46:26 +0000
Gerrit-HasComments: No