[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #311: [FLINK-29554] Add partial-update.ignore-delete option to avoid exception after join

[GitBox <gi...@apache.org>]

SteNicholas commented on code in PR #311:
URL: https://github.com/apache/flink-table-store/pull/311#discussion_r991985956


##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -170,6 +170,12 @@
             <td>MemorySize</td>
             <td>Memory page size.</td>
         </tr>
+        <tr>
+            <td><h5>partial-update.ignore-delete</h5></td>

Review Comment:
   The config option `partial-update.ignore-delete` doesn't include the update_before ignore meaning.



##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -170,6 +170,12 @@
             <td>MemorySize</td>
             <td>Memory page size.</td>
         </tr>
+        <tr>
+            <td><h5>partial-update.ignore-delete</h5></td>

Review Comment:
   The config option `partial-update.ignore-delete` doesn't include the `update_before` ignore meaning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org