You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by rmkellogg <gi...@git.apache.org> on 2015/06/05 17:40:59 UTC
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
GitHub user rmkellogg opened a pull request:
https://github.com/apache/storm/pull/580
STORM-852 - Replaced Apache Log4j Logger with SLF4J API.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmkellogg/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/580.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #580
----
commit f35871cf481d273b9de979a2034aa96458334b32
Author: Rick Kellogg <rm...@comcast.net>
Date: 2015-06-05T15:39:26Z
STORM-852 - Replaced Apache Log4j Logger with SLF4J API.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/580#issuecomment-110256170
LGTM.
Removed last comment cause logviewer.clj uses log4j2 directly, not log4j.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/580
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/580#issuecomment-110212096
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/580#issuecomment-109351076
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/580#issuecomment-109341798
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-852 - Replaced Apache Log4j Logger with ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/580#issuecomment-110216994
LGTM.
Could we apply it to clj implementations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---