[GitHub] [lucene] jpountz commented on a diff in pull request #11794: Guard FieldExistsQuery against null pointers

[GitBox <gi...@apache.org>]

jpountz commented on code in PR #11794:
URL: https://github.com/apache/lucene/pull/11794#discussion_r975093030


##########
lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java:
##########
@@ -702,6 +702,28 @@ private float[] randomVector(int dim) {
     return v;
   }
 
+  public void testDeleteAllPointDocs() throws Exception {
+    try (Directory dir = newDirectory();
+        RandomIndexWriter iw = new RandomIndexWriter(random(), dir)) {
+
+      Document doc = new Document();
+      doc.add(new StringField("id", "0", Field.Store.NO));
+      doc.add(new LongPoint("long", 17));
+      doc.add(new NumericDocValuesField("long", 17));
+      iw.addDocument(doc);
+      iw.addDocument(new Document());
+      iw.commit();
+
+      iw.deleteDocuments(new Term("id", "0"));
+      iw.forceMerge(1);

Review Comment:
   Do we need to add an `iw.flush()` call between the two `addDocument` calls? Otherwise there might already be a single segment and forceMerge will be a no-op. Maybe add an assertion below that the reader has a single segment without deletions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org