You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Oliverwqcwrw (via GitHub)" <gi...@apache.org> on 2023/01/25 06:27:58 UTC

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5922: [ISSUE #5921] Support domain resolution to obtain the controller address

Oliverwqcwrw commented on code in PR #5922:
URL: https://github.com/apache/rocketmq/pull/5922#discussion_r1086244993


##########
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java:
##########
@@ -448,6 +445,17 @@ private void stopCheckSyncStateSet() {
         }
     }
 
+    private void updateControlllerAddr() {

Review Comment:
   ```suggestion
       private void updateControllerAddr() {
   ```



##########
broker/src/main/java/org/apache/rocketmq/broker/controller/ReplicasManager.java:
##########
@@ -108,6 +103,8 @@ enum State {
     }
 
     public void start() {
+        updateControlllerAddr();

Review Comment:
   ```suggestion
           updateControllerAddr();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org