You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by willb <gi...@git.apache.org> on 2014/02/11 21:05:40 UTC
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
GitHub user willb opened a pull request:
https://github.com/apache/incubator-spark/pull/582
SPARK-1078: Replace lift-json with json4s-jackson.
The aim of the Json4s project is to provide a common API for
Scala JSON libraries. It is Apache-licensed, easier for
downstream distributions to package, and mostly API-compatible
with lift-json. Furthermore, the Jackson-backed implementation
parses faster than lift-json on all but the smallest inputs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-spark json4s
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-spark/pull/582.patch
----
commit 2c9f7f77849d83ab0b250c5fe80d8c599c2a8855
Author: William Benton <se...@willbenton.com>
Date: 2014-02-11T17:11:56Z
Replace lift-json with json4s-jackson.
The aim of the Json4s project is to provide a common API for
Scala JSON libraries. It is Apache-licensed, easier for
downstream distributions to package, and mostly API-compatible
with lift-json. Furthermore, the Jackson-backed implementation
parses faster than lift-json on all but the smallest inputs.
Squashed commit of the following:
commit d07b75538af5c8c4f698834aa4203ff8def69872
commit c54addda88cd9369aaeb22c5485630bf76450452
commit 2c1387f2f8e4798be9c8d4535cf2853ca3982a91
----
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801415
Merged build triggered.
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by willb <gi...@git.apache.org>.
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35887433
I'm not able to reproduce [this failure](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12819/testReport/) locally (either with my patch atop 437b62fcb, as it was when I updated my branch, or atop c0ef3afa, which Jenkins merged into when testing). Does anyone have any advice?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by willb <gi...@git.apache.org>.
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34931526
Thanks for the review, Aaron! After others have weighed in, I'll amend my branch to catch the right exception (and correct my email address).
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35849112
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35849113
One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12820/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35919353
Let's just try it again - Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35845761
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847835
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801246
Jenkins, add to whitelist.
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35954244
Looks good to me! Will merge soon, if no one else has comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34801416
Merged build started.
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34804702
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12680/
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34922638
This looks good to me, only significant change is correcting the thrown exception. I am somewhat underwhelmed by json4s's documentation. For instance, this file includes absolutely no docs, despite being of paramount importance to the library: https://github.com/json4s/json4s/blob/master/core/src/main/scala/org/json4s/JsonMethods.scala
Will also give more time for other potential reviewers and any further discussion on the dev list..
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by willb <gi...@git.apache.org>.
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34834423
The current version of json4s-jackson depends on paranamer 2.6, while the current version of lift-json depends on 2.4.1. That's the only difference that winds up getting pulled in by a Spark build, although json4s has an optional extension (not currently exercised by Spark AFAICT) to use joda-time 2.3 and joda-convert 1.5. Lift's dependencies on these joda libraries (also not exercised by Spark AFAICT) are on versions 2.1 and 1.2, respectively.
FasterXML claims that subsequent Jackson minor releases in a major series are backwards-compatible; looking at the version history, it doesn't appear that anything critical has been removed from 2.2.2 to 2.3.
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34799861
Can one of the admins verify this patch?
Re: [GitHub] incubator-spark pull request: SPARK-1078: Replace
lift-json with j...
Posted by Mark Hamstra <ma...@clearstorydata.com>.
Sounds good, now that we are all clear on what we mean. Didn't mean to be
a dick, just was a little confused on what you meant.
On Tue, Feb 11, 2014 at 8:08 PM, Patrick Wendell <pw...@gmail.com> wrote:
> I think Aaron just meant 1.0.0 by "the next minor release".
>
> On Tue, Feb 11, 2014 at 7:56 PM, Mark Hamstra <ma...@clearstorydata.com>
> wrote:
> >>
> >> The situation sounds fine for the next minor release...
> >
> >
> > I don't understand what you mean by this. According to my current
> > understanding, the next release of Spark other than maintenance releases
> on
> > 0.9.x is intended to be a major release, 1.0.0, and there are no plans
> for
> > an intervening minor release, which would be 0.10.0. Thus "the next
> minor
> > release" would be 1.1.0, and I fail to see why we would wait for that
> > instead of putting the dependency change (assuming that it is something
> > that we do, indeed, want) in 1.0.0.
> >
> >
> >
> > On Tue, Feb 11, 2014 at 7:51 PM, aarondav <gi...@git.apache.org> wrote:
> >
> >> Github user aarondav commented on the pull request:
> >>
> >>
> >>
> https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
> >>
> >> Thanks for looking into it! The situation sounds fine for the next
> >> minor release, and I don't think this patch needs to be included in the
> >> next maintenance release anyway (following your very own [suggestion](
> >> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser)
> >> on the dev list).
> >>
> >> While this patch looks good to me, I am not sure I fully understand
> >> the need for it. I posted my question on the [dev list thread](
> >>
> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E
> ).
> >> Besides the dependency change, you also mention performance
> improvements.
> >> [This benchmark](
> >> http://engineering.ooyala.com/blog/comparing-scala-json-libraries) does
> >> show Jackson outperforming lift on a particular workload, but do you
> have
> >> another source showing how the relative performance changes with input
> size?
> >>
> >>
>
Re: [GitHub] incubator-spark pull request: SPARK-1078: Replace
lift-json with j...
Posted by Patrick Wendell <pw...@gmail.com>.
I think Aaron just meant 1.0.0 by "the next minor release".
On Tue, Feb 11, 2014 at 7:56 PM, Mark Hamstra <ma...@clearstorydata.com> wrote:
>>
>> The situation sounds fine for the next minor release...
>
>
> I don't understand what you mean by this. According to my current
> understanding, the next release of Spark other than maintenance releases on
> 0.9.x is intended to be a major release, 1.0.0, and there are no plans for
> an intervening minor release, which would be 0.10.0. Thus "the next minor
> release" would be 1.1.0, and I fail to see why we would wait for that
> instead of putting the dependency change (assuming that it is something
> that we do, indeed, want) in 1.0.0.
>
>
>
> On Tue, Feb 11, 2014 at 7:51 PM, aarondav <gi...@git.apache.org> wrote:
>
>> Github user aarondav commented on the pull request:
>>
>>
>> https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
>>
>> Thanks for looking into it! The situation sounds fine for the next
>> minor release, and I don't think this patch needs to be included in the
>> next maintenance release anyway (following your very own [suggestion](
>> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser)
>> on the dev list).
>>
>> While this patch looks good to me, I am not sure I fully understand
>> the need for it. I posted my question on the [dev list thread](
>> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E).
>> Besides the dependency change, you also mention performance improvements.
>> [This benchmark](
>> http://engineering.ooyala.com/blog/comparing-scala-json-libraries) does
>> show Jackson outperforming lift on a particular workload, but do you have
>> another source showing how the relative performance changes with input size?
>>
>>
Re: [GitHub] incubator-spark pull request: SPARK-1078: Replace
lift-json with j...
Posted by Aaron Davidson <il...@gmail.com>.
My apologies, my intention was that it is fine for the next minor
*or*major release, regardless of what comes next. I only wanted to
distinguish
that from the next maintenance release, since my understanding is that we
wish to avoid changing dependencies during maintenance releases.
On Tue, Feb 11, 2014 at 7:56 PM, Mark Hamstra <ma...@clearstorydata.com>wrote:
> >
> > The situation sounds fine for the next minor release...
>
>
> I don't understand what you mean by this. According to my current
> understanding, the next release of Spark other than maintenance releases on
> 0.9.x is intended to be a major release, 1.0.0, and there are no plans for
> an intervening minor release, which would be 0.10.0. Thus "the next minor
> release" would be 1.1.0, and I fail to see why we would wait for that
> instead of putting the dependency change (assuming that it is something
> that we do, indeed, want) in 1.0.0.
>
>
>
> On Tue, Feb 11, 2014 at 7:51 PM, aarondav <gi...@git.apache.org> wrote:
>
> > Github user aarondav commented on the pull request:
> >
> >
> > https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
> >
> > Thanks for looking into it! The situation sounds fine for the next
> > minor release, and I don't think this patch needs to be included in the
> > next maintenance release anyway (following your very own [suggestion](
> > http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser)
> > on the dev list).
> >
> > While this patch looks good to me, I am not sure I fully understand
> > the need for it. I posted my question on the [dev list thread](
> >
> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E
> ).
> > Besides the dependency change, you also mention performance improvements.
> > [This benchmark](
> > http://engineering.ooyala.com/blog/comparing-scala-json-libraries) does
> > show Jackson outperforming lift on a particular workload, but do you have
> > another source showing how the relative performance changes with input
> size?
> >
> >
>
Re: [GitHub] incubator-spark pull request: SPARK-1078: Replace
lift-json with j...
Posted by Mark Hamstra <ma...@clearstorydata.com>.
>
> The situation sounds fine for the next minor release...
I don't understand what you mean by this. According to my current
understanding, the next release of Spark other than maintenance releases on
0.9.x is intended to be a major release, 1.0.0, and there are no plans for
an intervening minor release, which would be 0.10.0. Thus "the next minor
release" would be 1.1.0, and I fail to see why we would wait for that
instead of putting the dependency change (assuming that it is something
that we do, indeed, want) in 1.0.0.
On Tue, Feb 11, 2014 at 7:51 PM, aarondav <gi...@git.apache.org> wrote:
> Github user aarondav commented on the pull request:
>
>
> https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
>
> Thanks for looking into it! The situation sounds fine for the next
> minor release, and I don't think this patch needs to be included in the
> next maintenance release anyway (following your very own [suggestion](
> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser)
> on the dev list).
>
> While this patch looks good to me, I am not sure I fully understand
> the need for it. I posted my question on the [dev list thread](
> http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E).
> Besides the dependency change, you also mention performance improvements.
> [This benchmark](
> http://engineering.ooyala.com/blog/comparing-scala-json-libraries) does
> show Jackson outperforming lift on a particular workload, but do you have
> another source showing how the relative performance changes with input size?
>
>
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34836430
Thanks for looking into it! The situation sounds fine for the next minor release, and I don't think this patch needs to be included in the next maintenance release anyway (following your very own [suggestion](http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/browser) on the dev list).
While this patch looks good to me, I am not sure I fully understand the need for it. I posted my question on the [dev list thread](http://mail-archives.apache.org/mod_mbox/spark-dev/201402.mbox/%3C945190638.685798.1391974088596.JavaMail.zimbra%40redhat.com%3E). Besides the dependency change, you also mention performance improvements. [This benchmark](http://engineering.ooyala.com/blog/comparing-scala-json-libraries) does show Jackson outperforming lift on a particular workload, but do you have another source showing how the relative performance changes with input size?
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35930343
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12831/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34829822
Does json4s-jackson include any dependencies that lift-json doesn't? Does the versioning match?
It seems that this version of json4s-jackson pulls in jackson 2.3.0, whereas currently our dependencies are pulling in 2.2.2. Are these versions binary compatible, or could we see issues crop up?
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847507
One or more automated tests failed
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12819/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35845760
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35923427
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35930342
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by willb <gi...@git.apache.org>.
Github user willb commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35837078
Yes, I'll make the changes today. Thanks, Aaron!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by aarondav <gi...@git.apache.org>.
Github user aarondav commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35817227
There is some desire to get this change in as we have a PR in the pipeline that will use our JSON serialization library more heavily to serialize and log SparkListener events, so it would be nice to test that with this patch in.
Do you think it'd be possible to bring this patch up to date with the comments previously given?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847834
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35923428
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35847506
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastructure@apache.org or file a JIRA ticket with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-35920859
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-spark pull request: SPARK-1078: Replace lift-json with j...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/incubator-spark/pull/582#issuecomment-34804701
Merged build finished.