You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2017/03/16 23:34:42 UTC
[jira] [Commented] (AIRFLOW-984) Subdags unrecognized when
subclassing SubDagOperator
[ https://issues.apache.org/jira/browse/AIRFLOW-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929145#comment-15929145 ]
ASF subversion and git services commented on AIRFLOW-984:
---------------------------------------------------------
Commit a8bd1695e44e56375a399a9c7a0af0b137922e24 in incubator-airflow's branch refs/heads/master from [~patrickmckenna]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-airflow.git;h=a8bd169 ]
[AIRFLOW-984] Enable subclassing of SubDagOperator
Note this maintains an awkward name check
for backwards compatibility reasons.
Closes #2152 from patrickmckenna/recognize-subdag-
subclasses
> Subdags unrecognized when subclassing SubDagOperator
> ----------------------------------------------------
>
> Key: AIRFLOW-984
> URL: https://issues.apache.org/jira/browse/AIRFLOW-984
> Project: Apache Airflow
> Issue Type: Bug
> Reporter: Patrick McKenna
> Priority: Minor
> Fix For: 1.9.0
>
>
> If a user subclasses SubDagOperator, the parent DAG will not pick up the subdags:
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L2974
> which means a DagBag won't find them:
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L311
> https://github.com/apache/incubator-airflow/blob/c44e2009ee625ce4a82c50e585a3c8617d9b4ff8/airflow/models.py#L365
> This PR appears to be the cause: https://github.com/apache/incubator-airflow/pull/1196/files.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)