[GitHub] [ozone] Galsza commented on a diff in pull request #4792: HDDS-8694. Add SCM HA aware Root CA certificate monitor task

["Galsza (via GitHub)" <gi...@apache.org>]

Galsza commented on code in PR #4792:
URL: https://github.com/apache/ozone/pull/4792#discussion_r1216717113


##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2234,6 +2234,24 @@
       they can be configured separately.
     </description>
   </property>
+  <property>
+    <name>hdds.x509.ca.rotation.check.interval</name>
+    <value>P1D</value>
+    <tag>OZONE, HDDS, SECURITY</tag>
+    <description>Check interval of whether internal root certificate is going
+      to expire and needs to start rotation or not. Default is 1 day. The property
+      value should be less than the value of property hdds.x509.renew.grace.duration.
+    </description>
+  </property>
+  <property>
+    <name>hdds.x509.ca.rotation.time-of-day</name>
+    <value>02:00:00</value>
+    <tag>OZONE, HDDS, SECURITY</tag>
+    <description>Time of day to start the rotation. Default 02:00 AM to avoid impact

Review Comment:
   ```suggestion
       <description>Time of day to start the rotation. Default 02:00 AM to avoid impacting
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org