You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/25 22:43:36 UTC
Review Request: Better verbose output for killtree.sh.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5239/
-----------------------------------------------------------
Review request for mesos, John Sirois and Vinod Kone.
Summary
-------
See summary.
Diffs
-----
src/scripts/killtree.sh 3d89cbc
Diff: https://reviews.apache.org/r/5239/diff
Testing
-------
Thanks,
Benjamin
Re: Review Request: Better verbose output for killtree.sh.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-05-25 20:51:52, John Sirois wrote:
> > src/scripts/killtree.sh, line 228
> > <https://reviews.apache.org/r/5239/diff/1/?file=110282#file110282line228>
> >
> > is [[ ]] /bin/sh? I though double [[ was bash
>From the specification:
---------------------------
The following words may be recognized as reserved words on some implementations (when none of the characters are quoted), causing unspecified results:
[[ ]] function select
---------------------------
I'll switch the file to be /bin/bash. Thanks.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5239/#review8119
-----------------------------------------------------------
On 2012-05-25 20:43:36, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5239/
> -----------------------------------------------------------
>
> (Updated 2012-05-25 20:43:36)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scripts/killtree.sh 3d89cbc
>
> Diff: https://reviews.apache.org/r/5239/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: Better verbose output for killtree.sh.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5239/#review8119
-----------------------------------------------------------
Ship it!
src/scripts/killtree.sh
<https://reviews.apache.org/r/5239/#comment17641>
is [[ ]] /bin/sh? I though double [[ was bash
- John
On 2012-05-25 20:43:36, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5239/
> -----------------------------------------------------------
>
> (Updated 2012-05-25 20:43:36)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/scripts/killtree.sh 3d89cbc
>
> Diff: https://reviews.apache.org/r/5239/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>