[GitHub] [accumulo] ctubbsii commented on a change in pull request #1715: Deprecation of VFS Class Loader items, new Context class loader management

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1715:
URL: https://github.com/apache/accumulo/pull/1715#discussion_r502007330



##########
File path: core/src/main/java/org/apache/accumulo/core/spi/common/ContextClassLoaderFactory.java
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.spi.common;
+
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.Map.Entry;
+
+/**
+ * The ContextClassLoaderFactory implementation is defined by the property
+ * general.context.class.loader.factory. The implementation is configured externally to Accumulo and
+ * will return a ClassLoader for a given contextName.
+ */
+public interface ContextClassLoaderFactory {
+
+  static class ClassLoaderFactoryConfiguration {

Review comment:
       They shouldn't inherit from the outer class, but it's also package-private, so it shouldn't matter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org