[jira] [Commented] (OAK-1655) DataStoreBlobStore does not take into maxLastModifiedTime when fetching all chunks

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956337#comment-13956337 ] 

Thomas Mueller commented on OAK-1655:
-------------------------------------

The GarbageCollectableBlobStore.deleteChunks also has a maxLastModifiedTime parameter. If deleteChunks is implemented correctly (and called correctly), then new binaries should not be deleted. So I don't think this TODO will cause trouble for garbage collection.

On the other hand, it's true that the parameter shouldn't be ignored as it is now.

> DataStoreBlobStore does not take into maxLastModifiedTime when fetching all chunks
> ----------------------------------------------------------------------------------
>
>                 Key: OAK-1655
>                 URL: https://issues.apache.org/jira/browse/OAK-1655
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 0.20
>
>
> Currently the {{DataStoreBlobStore}} has a pending TODO
> {code}
>  @Override
>     public Iterator<String> getAllChunkIds(long maxLastModifiedTime) throws Exception {
>         //TODO Ignores the maxLastModifiedTime currently.
>         return Iterators.transform(delegate.getAllIdentifiers(), new Function<DataIdentifier, String>() {
>             @Nullable
>             @Override
>             public String apply(@Nullable DataIdentifier input) {
>                 return input.toString();
>             }
>         });
>     }
> {code}
> Due to this it currently returns all blobId. This would issue when new binary gets created while a blob gc is running as such binaries might be considered orphan and deleted



--
This message was sent by Atlassian JIRA
(v6.2#6252)