You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/03/05 01:41:27 UTC

[jira] Created: (HBASE-2288) Shell fails on alter

Shell fails on alter
--------------------

                 Key: HBASE-2288
                 URL: https://issues.apache.org/jira/browse/HBASE-2288
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: Jean-Daniel Cryans
            Assignee: Jean-Daniel Cryans
             Fix For: 0.20.4


HBASE-2035 added this line to branch which doesn't make sense since it's related to a Trunk feature:

{code}
        if args[DEFERRED_LOG_FLUSH]
          htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
        end
{code}

We just need to remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2288) Shell fails on alter

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-2288.
---------------------------------------

    Resolution: Fixed

> Shell fails on alter
> --------------------
>
>                 Key: HBASE-2288
>                 URL: https://issues.apache.org/jira/browse/HBASE-2288
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.4
>
>
> HBASE-2035 added this line to branch which doesn't make sense since it's related to a Trunk feature:
> {code}
>         if args[DEFERRED_LOG_FLUSH]
>           htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
>         end
> {code}
> We just need to remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2288) Shell fails on alter

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841647#action_12841647 ] 

Jean-Daniel Cryans commented on HBASE-2288:
-------------------------------------------

Nope, not until HBASE-1944 is backported.

> Shell fails on alter
> --------------------
>
>                 Key: HBASE-2288
>                 URL: https://issues.apache.org/jira/browse/HBASE-2288
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.4
>
>
> HBASE-2035 added this line to branch which doesn't make sense since it's related to a Trunk feature:
> {code}
>         if args[DEFERRED_LOG_FLUSH]
>           htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
>         end
> {code}
> We just need to remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2288) Shell fails on alter

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841643#action_12841643 ] 

stack commented on HBASE-2288:
------------------------------

Do I need to add this back after backport of group commit? HBASE-1939?

> Shell fails on alter
> --------------------
>
>                 Key: HBASE-2288
>                 URL: https://issues.apache.org/jira/browse/HBASE-2288
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.4
>
>
> HBASE-2035 added this line to branch which doesn't make sense since it's related to a Trunk feature:
> {code}
>         if args[DEFERRED_LOG_FLUSH]
>           htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
>         end
> {code}
> We just need to remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2288) Shell fails on alter

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841629#action_12841629 ] 

Jean-Daniel Cryans commented on HBASE-2288:
-------------------------------------------

I committed this to branch:

{code}
Index: bin/HBase.rb
===================================================================
--- bin/HBase.rb	(revision 919248)
+++ bin/HBase.rb	(working copy)
@@ -231,9 +231,6 @@
         if args[MEMSTORE_FLUSHSIZE]
           htd.setMemStoreFlushSize(JLong.valueOf(args[MEMSTORE_FLUSHSIZE]))
         end
-        if args[DEFERRED_LOG_FLUSH]
-          htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
-        end
         @admin.modifyTable(tableName.to_java_bytes, htd)
       else
         descriptor = hcd(args)
{code}

> Shell fails on alter
> --------------------
>
>                 Key: HBASE-2288
>                 URL: https://issues.apache.org/jira/browse/HBASE-2288
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.4
>
>
> HBASE-2035 added this line to branch which doesn't make sense since it's related to a Trunk feature:
> {code}
>         if args[DEFERRED_LOG_FLUSH]
>           htd.setDeferredLogFlush(JBoolean.valueOf(args[DEFERRED_LOG_FLUSH]))
>         end
> {code}
> We just need to remove it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.