[jira] [Commented] (ZOOKEEPER-2349) Update documentation for snapCount

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141061#comment-16141061 ] 

ASF GitHub Bot commented on ZOOKEEPER-2349:
-------------------------------------------

GitHub user maoling opened a pull request:

    https://github.com/apache/zookeeper/pull/349

    ZOOKEEPER-2349:Update documentation for snapCount

    Origin patch can not apply now and it has something inaccurate.so I give it a new PR.
    more details in [JIRA](https://issues.apache.org/jira/browse/ZOOKEEPER-2349)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-2349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #349
    
----
commit 29aa87863d6a5de3886c324ecd50b4f960d100b2
Author: maoling <ma...@sina.com>
Date:   2017-08-25T01:13:28Z

    ZOOKEEPER-2349:Update documentation for snapCount

----


> Update documentation for snapCount
> ----------------------------------
>
>                 Key: ZOOKEEPER-2349
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2349
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Raghavendra Prabhu
>            Priority: Minor
>         Attachments: ZOOKEEPER-2349.patch
>
>
> The documentation states that 
> {code}
> ZooKeeper logs transactions to a transaction
> log. After snapCount transactions are written to a log
> file a snapshot is started and a new transaction log
> file is created. The default snapCount is
> 100,000.
> {code}
> However, in implementation, snapshotting is done when logCount is somwhere in (snapCount/2, snapCount+1], based on the limit set at runtime:  
> {code}
>         if (logCount > (snapCount / 2 + randRoll)) {
> {code}
> as in 
> https://github.com/apache/zookeeper/blob/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java#L124



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)