You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2016/04/22 14:05:33 UTC
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1510
4.9 mvn version safeupgradeonly
Upgrades maven dependencies versions that can be safely upgraded without breaking console-proxy/crypto usage.
Bisected changes from: https://github.com/apache/cloudstack/pull/1397
cc @swill @DaanHoogland
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack 4.9-mvn-version-safeupgradeonly
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1510.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1510
----
commit bb29b1d06389e41c779d94f2d433f3b7c48009b3
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-27T00:41:02Z
maven: Upgrade dependency versions
Updated most dependencies to latest minor releases, EXCEPT:
- Gson 2.x
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit 770aa0133ee3011239033e2dfe3f6ed41b76761a
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-02-02T18:55:06Z
framework/quota: fix checkstyle issue
Fixes enum name to supress checkstyle failure due to the latest checkstyle
version
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit 101668994dd27e3ca67c09a8118dbcea255805fd
Author: Daan Hoogland <da...@onecht.net>
Date: 2016-04-22T10:55:27Z
further maven dependency updates from Daan
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
commit 8af677a0f0b2a74db74223fc3d0e2d3e9549e960
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2016-01-28T12:06:08Z
maven: fix dependency version support by JDK7
- Fix jetty dependency that is compatible with Java7
- Upgrade minor revisions of dependencies
- Upgrade vmware mvn sdk dependency to 6.0
- Downgrade bounty castle version to 1.46 (same as before)
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215048942
LGTM, i had run the tests as well, with no more then the usual problems &*%(^%. Note that part of the change is mine when you take my lgtm for it;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214999606
Compiled the code using JDK8 (1.8.0_65) and ran unit tests, works on my system.
Based on the code changes: LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214480008
@swill busy on this one yet? I am looking to run it as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214620580
@swill thanks, this can be merged first as we wait for bountycastle related changes to work with openjdk 1.7.0_95+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213521104
@swill please include this PR in your list, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1510
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214965449
This one is ready pending at least one LGTM vote...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-215081538
Thank you gentlemen. I think this one is ready now. 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214480409
go ahead. I am trying to get to the bottom of marvin being strange right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213398409
With this change we would be able to use JDK8 for building cloudstack once we fix the build issues of F5 plugin (that's the only component that fails to build with javac 1.8 now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214960615
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__Apr_26_2016_20_17_04_VKI7EV:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/DeployDataCenter__Apr_26_2016_20_17_04_VKI7EV/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/DeployDataCenter__Apr_26_2016_20_17_04_VKI7EV/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/DeployDataCenter__Apr_26_2016_20_17_04_VKI7EV/runinfo.txt)
**`/tmp/MarvinLogs/test_network_0G1KRM:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_network_0G1KRM/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_network_0G1KRM/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_network_0G1KRM/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_JIBRWD:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_vpc_routers_JIBRWD/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_vpc_routers_JIBRWD/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1510/tmp/MarvinLogs/test_vpc_routers_JIBRWD/runinfo.txt)
Uploads will be available until `2016-06-27 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-214992687
@DaanHoogland @wido @jburwell review/lgtm please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213558371
@bhaisaab @swill it is important to note that Spring 3 only supports running JDK8 for applications built using a target version of 1.7. Applications built using Spring 3 a 1.8 version target will be unstable and eventually crash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: 4.9 mvn version safeupgradeonly
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213540008
@bhaisaab yep, already got it. 👍
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---