You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/03/18 15:27:20 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3939: HBASE-26565 Make StatisticThread alternative in LruBC

Apache9 commented on a change in pull request #3939:
URL: https://github.com/apache/hbase/pull/3939#discussion_r830109549



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FirstLevelBlockCache.java
##########
@@ -17,22 +17,42 @@
  */
 package org.apache.hadoop.hbase.io.hfile;
 
+import java.util.concurrent.Executors;
+import java.util.concurrent.ScheduledExecutorService;
+import java.util.concurrent.TimeUnit;
 import org.apache.hadoop.hbase.io.HeapSize;
+import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder;
 import org.apache.yetus.audience.InterfaceAudience;
 
 /**
  * In-memory BlockCache that may be backed by secondary layer(s).
  */
 @InterfaceAudience.Private
-public interface FirstLevelBlockCache extends ResizableBlockCache, HeapSize {
+public abstract class FirstLevelBlockCache implements ResizableBlockCache, HeapSize {
+
+  /* Statistics thread */
+  protected static String STAT_THREAD_ENABLE_KEY = "hbase.lru.stat.enable";
+  protected static boolean STAT_THREAD_ENABLE_DEFAULT = false;

Review comment:
       As said in #3956 , we'd better set it to true in this PR, and file another PR to change to true on master branch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org