You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/11/29 02:40:51 UTC
Change in asterixdb[master]: remove more useless curly braces
Till Westmann has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1363
Change subject: remove more useless curly braces
......................................................................
remove more useless curly braces
Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
1 file changed, 14 insertions(+), 28 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/63/1363/1
diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
index 8e424ec..a819b67 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
@@ -45,58 +45,44 @@
case DATE:
case TIME:
case YEARMONTHDURATION:
- case INT32: {
+ case INT32:
return new AWrappedAscNormalizedKeyComputerFactory(new IntegerNormalizedKeyComputerFactory());
- }
case DATETIME:
case DAYTIMEDURATION:
- case INT64: {
+ case INT64:
return new AWrappedAscNormalizedKeyComputerFactory(new Integer64NormalizedKeyComputerFactory());
- }
- case FLOAT: {
+ case FLOAT:
return new AWrappedAscNormalizedKeyComputerFactory(new FloatNormalizedKeyComputerFactory());
- }
- case DOUBLE: {
+ case DOUBLE:
return new AWrappedAscNormalizedKeyComputerFactory(new DoubleNormalizedKeyComputerFactory());
- }
- case STRING: {
+ case STRING:
return new AWrappedAscNormalizedKeyComputerFactory(new UTF8StringNormalizedKeyComputerFactory());
- }
- case BINARY: {
+ case BINARY:
return new AWrappedAscNormalizedKeyComputerFactory(new ByteArrayNormalizedKeyComputerFactory());
- }
- default: {
+ default:
return null;
- }
}
} else {
switch (aqlType.getTypeTag()) {
case DATE:
case TIME:
case YEARMONTHDURATION:
- case INT32: {
+ case INT32:
return new AWrappedDescNormalizedKeyComputerFactory(new IntegerNormalizedKeyComputerFactory());
- }
case DATETIME:
case DAYTIMEDURATION:
- case INT64: {
+ case INT64:
return new AWrappedDescNormalizedKeyComputerFactory(new Integer64NormalizedKeyComputerFactory());
- }
- case FLOAT: {
+ case FLOAT:
return new AWrappedDescNormalizedKeyComputerFactory(new FloatNormalizedKeyComputerFactory());
- }
- case DOUBLE: {
+ case DOUBLE:
return new AWrappedDescNormalizedKeyComputerFactory(new DoubleNormalizedKeyComputerFactory());
- }
- case STRING: {
+ case STRING:
return new AWrappedDescNormalizedKeyComputerFactory(new UTF8StringNormalizedKeyComputerFactory());
- }
- case BINARY: {
+ case BINARY:
return new AWrappedDescNormalizedKeyComputerFactory(new ByteArrayNormalizedKeyComputerFactory());
- }
- default: {
+ default:
return null;
- }
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Change in asterixdb[master]: remove more useless curly braces
Posted by "abdullah alamoudi (Code Review)" <do...@asterixdb.incubator.apache.org>.
abdullah alamoudi has posted comments on this change.
Change subject: remove more useless curly braces
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: remove more useless curly braces
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: remove more useless curly braces
......................................................................
Patch Set 1:
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1204/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: remove more useless curly braces
Posted by "Till Westmann (Code Review)" <do...@asterixdb.incubator.apache.org>.
Till Westmann has submitted this change and it was merged.
Change subject: remove more useless curly braces
......................................................................
remove more useless curly braces
Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1363
Reviewed-by: abdullah alamoudi <ba...@gmail.com>
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
1 file changed, 14 insertions(+), 28 deletions(-)
Approvals:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found
diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
index 8e424ec..a819b67 100644
--- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
+++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/formats/nontagged/AqlNormalizedKeyComputerFactoryProvider.java
@@ -45,58 +45,44 @@
case DATE:
case TIME:
case YEARMONTHDURATION:
- case INT32: {
+ case INT32:
return new AWrappedAscNormalizedKeyComputerFactory(new IntegerNormalizedKeyComputerFactory());
- }
case DATETIME:
case DAYTIMEDURATION:
- case INT64: {
+ case INT64:
return new AWrappedAscNormalizedKeyComputerFactory(new Integer64NormalizedKeyComputerFactory());
- }
- case FLOAT: {
+ case FLOAT:
return new AWrappedAscNormalizedKeyComputerFactory(new FloatNormalizedKeyComputerFactory());
- }
- case DOUBLE: {
+ case DOUBLE:
return new AWrappedAscNormalizedKeyComputerFactory(new DoubleNormalizedKeyComputerFactory());
- }
- case STRING: {
+ case STRING:
return new AWrappedAscNormalizedKeyComputerFactory(new UTF8StringNormalizedKeyComputerFactory());
- }
- case BINARY: {
+ case BINARY:
return new AWrappedAscNormalizedKeyComputerFactory(new ByteArrayNormalizedKeyComputerFactory());
- }
- default: {
+ default:
return null;
- }
}
} else {
switch (aqlType.getTypeTag()) {
case DATE:
case TIME:
case YEARMONTHDURATION:
- case INT32: {
+ case INT32:
return new AWrappedDescNormalizedKeyComputerFactory(new IntegerNormalizedKeyComputerFactory());
- }
case DATETIME:
case DAYTIMEDURATION:
- case INT64: {
+ case INT64:
return new AWrappedDescNormalizedKeyComputerFactory(new Integer64NormalizedKeyComputerFactory());
- }
- case FLOAT: {
+ case FLOAT:
return new AWrappedDescNormalizedKeyComputerFactory(new FloatNormalizedKeyComputerFactory());
- }
- case DOUBLE: {
+ case DOUBLE:
return new AWrappedDescNormalizedKeyComputerFactory(new DoubleNormalizedKeyComputerFactory());
- }
- case STRING: {
+ case STRING:
return new AWrappedDescNormalizedKeyComputerFactory(new UTF8StringNormalizedKeyComputerFactory());
- }
- case BINARY: {
+ case BINARY:
return new AWrappedDescNormalizedKeyComputerFactory(new ByteArrayNormalizedKeyComputerFactory());
- }
- default: {
+ default:
return null;
- }
}
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Change in asterixdb[master]: remove more useless curly braces
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: remove more useless curly braces
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/3401/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: remove more useless curly braces
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: remove more useless curly braces
......................................................................
Patch Set 1:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1204/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1363
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I581d268b12017fcf17b5b29f7183e07deae6e931
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <ba...@gmail.com>
Gerrit-HasComments: No