You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/14 11:52:04 UTC
[GitHub] [flink] ruanshubin opened a new pull request #19078: [FLINK-26629][runtime] fix bug in code comment of SubtaskStateMapper.RANGE
ruanshubin opened a new pull request #19078:
URL: https://github.com/apache/flink/pull/19078
## What is the purpose of the change
fix bug in code comment of SubtaskStateMapper.RANGE
## Brief change log
The code comments for SubtaskStateMapper.RANGE are as follows:
```
* <p>Example:<br>
* old assignment: 0 -> [0;43); 1 -> [43;87); 2 -> [87;128)<br>
* new assignment: 0 -> [0;64]; 1 -> [64;128)<br>
* subtask 0 recovers data from old subtask 0 + 1 and subtask 1 recovers data from old subtask 0
* + 2
```
The correct code comment should be：
```
* <p>Example:<br>
* old assignment: 0 -> [0;43); 1 -> [43;87); 2 -> [87;128)<br>
* new assignment: 0 -> [0;64]; 1 -> [64;128)<br>
* subtask 0 recovers data from old subtask 0 + 1 and subtask 1 recovers data from old subtask 1
* + 2
```
**subtask 1 should recovers data from old subtask 1 + 2，not from old subtask 0 + 2**
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19078: [FLINK-26629][runtime] fix bug in code comment of SubtaskStateMapper.RANGE
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19078:
URL: https://github.com/apache/flink/pull/19078#issuecomment-1066745628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33017",
"triggerID" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a0127f869aa87a948687d8e28d89dd27cd87f68 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19078: [FLINK-26629][runtime] fix bug in code comment of SubtaskStateMapper.RANGE
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19078:
URL: https://github.com/apache/flink/pull/19078#issuecomment-1066745628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a0127f869aa87a948687d8e28d89dd27cd87f68 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #19078: [FLINK-26629][runtime] fix bug in code comment of SubtaskStateMapper.RANGE
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19078:
URL: https://github.com/apache/flink/pull/19078#issuecomment-1066745628
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33017",
"triggerID" : "1a0127f869aa87a948687d8e28d89dd27cd87f68",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a0127f869aa87a948687d8e28d89dd27cd87f68 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=33017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys merged pull request #19078: [FLINK-26629][runtime] fix bug in code comment of SubtaskStateMapper.RANGE
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #19078:
URL: https://github.com/apache/flink/pull/19078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org