You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@freemarker.apache.org by Mads Bredholt <ma...@gmail.com> on 2026/04/19 11:17:50 UTC

[FREEMARKER-209] Trivial typo fix PR — and hello.

Hi all,

I'm Mads Bredholt, new to the project. ICLA submitted to
secretary@apache.org  on 18th april 2026.

I've opened a small PR for FREEMARKER-209 — a typo ("estabilished" →
"established")
in the naming-convention mismatch error message, and the same typo in a nearby
code comment in FTL.jj:

https://github.com/apache/freemarker/pull/126

Scope is deliberately minimal: just the two text occurrences. The same
misspelling
also appears in the field name `namingConventionEstabilisher`, but renaming that
expands the generated-parser diff, so I've left it as a possible follow-up if
reviewers think it's worth doing.

Thanks,
Mads

Re: [FREEMARKER-209] Trivial typo fix PR — and hello.

Posted by Daniel Dekany <da...@gmail.com>.
Thanks, I have merged it.

If the typo appears in public names (or in configuration files), we have to
keep backward compatibility. So the fixed name can be introduced as an
alternative name, but it usually comes at the price of added code
complexity, so perhaps it is not worth it.

On Sun, Apr 19, 2026 at 1:18 PM Mads Bredholt <ma...@gmail.com> wrote:

> Hi all,
>
> I'm Mads Bredholt, new to the project. ICLA submitted to
> secretary@apache.org  on 18th april 2026.
>
> I've opened a small PR for FREEMARKER-209 — a typo ("estabilished" →
> "established")
> in the naming-convention mismatch error message, and the same typo in a
> nearby
> code comment in FTL.jj:
>
> https://github.com/apache/freemarker/pull/126
>
> Scope is deliberately minimal: just the two text occurrences. The same
> misspelling
> also appears in the field name `namingConventionEstabilisher`, but
> renaming that
> expands the generated-parser diff, so I've left it as a possible follow-up
> if
> reviewers think it's worth doing.
>
> Thanks,
> Mads
>


-- 
Best regards,
Daniel Dekany