You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@auron.apache.org by "guixiaowen (via GitHub)" <gi...@apache.org> on 2026/05/06 19:33:16 UTC
[PR] [AURON #2240] Implement native function of make_date #2240 [auron]
guixiaowen opened a new pull request, #2241:
URL: https://github.com/apache/auron/pull/2241
# Which issue does this PR close?
Closes #2240
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
# How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2240] Implement native function of make_date #2240 [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 merged PR #2241:
URL: https://github.com/apache/auron/pull/2241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2240] Implement native function of make_date #2240 [auron]
Posted by "guixiaowen (via GitHub)" <gi...@apache.org>.
guixiaowen commented on PR #2241:
URL: https://github.com/apache/auron/pull/2241#issuecomment-4417728525
> @guixiaowen Thanks for the contribution! Merged.
@slfan1989 Thanks for your review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2240] Implement native function of make_date #2240 [auron]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2241:
URL: https://github.com/apache/auron/pull/2241#discussion_r3214489765
##########
spark-extension-shims-spark/src/test/scala/org/apache/auron/AuronFunctionSuite.scala:
##########
@@ -997,6 +998,23 @@ class AuronFunctionSuite extends AuronQueryTest with BaseAuronSQLSuite {
}
}
+ test("test function make_date") {
+ withTable("t1") {
+ sql(
+ "create table t1 using parquet as select '2025'" +
+ " as year, '03' as month, '01' as day")
+ val functions =
+ """
+ |select
+ | make_date(year, month, day)
+ |from t1
+ """.stripMargin
+
+ val df = sql(functions)
+ checkAnswer(df, Seq(Row(Date.valueOf("2025-03-01"))))
Review Comment:
The new make_date test uses `checkAnswer` with a hard-coded expected value, so it doesn't verify (1) that Auron matches vanilla Spark semantics, or (2) that the query plan is fully native (most other function tests use `checkSparkAnswerAndOperator` for this). Consider switching to `checkSparkAnswerAndOperator("select make_date(year, month, day) from t1")` and adding a couple of additional rows to cover null propagation / invalid month/day behavior (Spark returns null for invalid dates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AURON #2240] Implement native function of make_date #2240 [auron]
Posted by "slfan1989 (via GitHub)" <gi...@apache.org>.
slfan1989 commented on PR #2241:
URL: https://github.com/apache/auron/pull/2241#issuecomment-4417111852
@guixiaowen Thanks for the contribution! Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org