You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Marc Cappelletti <ma...@gmail.com> on 2023/09/27 08:32:16 UTC
Pull request
Hello,
I'm a new contributor and I have a pull request:
https://github.com/apache/commons-lang/pull/1114
Is everything okay for a review or do I need to publish the link somewhere,
like in this dev list? :)
Thanks for your information,
--
Marc Cappelletti
Re: [LANG] Extend "EqualsBuilder (Was: Pull request)
Posted by Marc Cappelletti <ma...@gmail.com>.
Hello all,
Just a comment that my ICLA has been filled.
The jira for the PR https://github.com/apache/commons-lang/pull/1114 is
https://issues.apache.org/jira/browse/LANG-1712
Now heading to address the comments.
Marc
Le mer. 27 sept. 2023 à 12:35, Gilles Sadowski <gi...@gmail.com> a
écrit :
> Hello.
>
> Le mer. 27 sept. 2023 à 11:48, Marc Cappelletti
> <ma...@gmail.com> a écrit :
> >
> > Hello Gilles,
> >
> > Thanks for the details and the comment.
>
> Thanks for your interest in contributing.
>
> >
> > By the way, do we comment directly on the PR
>
> Many people mostly do it on GH (which shuns people who don't
> want to register with GH...). Alternatively, implementation details
> can be discussed in JIRA comments.
>
> > or strictly via this mailing
> > list?
>
> New features and major changes should be approved on this ML.
> Once done, technical discussions will likely occur in one or the
> other venue mentioned above.
>
> Regards,
> Gilles
>
> >> [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [LANG] Extend "EqualsBuilder (Was: Pull request)
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le mer. 27 sept. 2023 à 11:48, Marc Cappelletti
<ma...@gmail.com> a écrit :
>
> Hello Gilles,
>
> Thanks for the details and the comment.
Thanks for your interest in contributing.
>
> By the way, do we comment directly on the PR
Many people mostly do it on GH (which shuns people who don't
want to register with GH...). Alternatively, implementation details
can be discussed in JIRA comments.
> or strictly via this mailing
> list?
New features and major changes should be approved on this ML.
Once done, technical discussions will likely occur in one or the
other venue mentioned above.
Regards,
Gilles
>> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [LANG] Extend "EqualsBuilder (Was: Pull request)
Posted by Marc Cappelletti <ma...@gmail.com>.
Hello Gilles,
Thanks for the details and the comment.
By the way, do we comment directly on the PR or strictly via this mailing
list?
Kind regards,
Marc
Le mer. 27 sept. 2023 à 11:30, Gilles Sadowski <gi...@gmail.com> a
écrit :
> Hello.
>
> As this list is shared among many (30+) "components" of the "Commons"
> project, the "Subject: " line should be prefixed by the "id" of the
> component
> (in this case: "[LANG] Pull request"). It is also nice if the subject
> line is a
> bit more specific (in this case: "[LANG] Extend "EqualsBuilder"), so that
> it
> draws the attention of the regular maintainer(s) of that part of the
> library.
>
> Le mer. 27 sept. 2023 à 10:33, Marc Cappelletti
> <ma...@gmail.com> a écrit :
> >
> > Hello,
> >
> > I'm a new contributor and I have a pull request:
> > https://github.com/apache/commons-lang/pull/1114
>
> Increasing a field visibility (in this case removing the "private"
> qualifier
> of "isEquals") is rarely a good idea.
>
> Wouldn't it be possible to add the capability to the existing class?
> If not, perhaps via adding a ("protected") helper method or constructor?
>
> >
> > Is everything okay for a review or do I need to publish the link
> somewhere,
> > like in this dev list? :)
> >
>
> For tracking purposes, please file a JIRA report:
> https://issues.apache.org/jira/projects/LANG
>
> Thanks,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
[LANG] Extend "EqualsBuilder (Was: Pull request)
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
As this list is shared among many (30+) "components" of the "Commons"
project, the "Subject: " line should be prefixed by the "id" of the component
(in this case: "[LANG] Pull request"). It is also nice if the subject line is a
bit more specific (in this case: "[LANG] Extend "EqualsBuilder"), so that it
draws the attention of the regular maintainer(s) of that part of the library.
Le mer. 27 sept. 2023 à 10:33, Marc Cappelletti
<ma...@gmail.com> a écrit :
>
> Hello,
>
> I'm a new contributor and I have a pull request:
> https://github.com/apache/commons-lang/pull/1114
Increasing a field visibility (in this case removing the "private" qualifier
of "isEquals") is rarely a good idea.
Wouldn't it be possible to add the capability to the existing class?
If not, perhaps via adding a ("protected") helper method or constructor?
>
> Is everything okay for a review or do I need to publish the link somewhere,
> like in this dev list? :)
>
For tracking purposes, please file a JIRA report:
https://issues.apache.org/jira/projects/LANG
Thanks,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org