[Trinidad] Fix contribution: commit or patch?

[Andrew Robinson <an...@gmail.com>]

Some open source projects differ on code responsibility and bug
fixing, and I want to make sure I don't step on people's toes. Lately
I have been using Trinidad on a side project and have been finding
bugs and areas for small enhancements, as many will realize.

I want to know if it is more customary in the Trinidad project to
create SVN patches attached to bugs or to just commit the fix right
into SVN if I am not the original author?

If direct committing is okay, is there a wiki or page that describes
anything that should be done to ensure that JIRA tracks the SVN commit
for a given bug?

Thank you,
Andrew

Re: [Trinidad] Fix contribution: commit or patch?

[Adam Winer <aw...@gmail.com>]

Generally speaking, it's good for non-trivial changes to
have JIRA issues, and to reference the JIRA issue
in the SVN commit.  If someone has commit rights,
there's no real advantage to attaching the patch to the
issue (since referencing the JIRA issue in the SVN
commit ties that change in anyway).

-- Adam


On 8/27/07, Andrew Robinson <an...@gmail.com> wrote:
> Some open source projects differ on code responsibility and bug
> fixing, and I want to make sure I don't step on people's toes. Lately
> I have been using Trinidad on a side project and have been finding
> bugs and areas for small enhancements, as many will realize.
>
> I want to know if it is more customary in the Trinidad project to
> create SVN patches attached to bugs or to just commit the fix right
> into SVN if I am not the original author?
>
> If direct committing is okay, is there a wiki or page that describes
> anything that should be done to ensure that JIRA tracks the SVN commit
> for a given bug?
>
> Thank you,
> Andrew
>

Re: [Trinidad] Fix contribution: commit or patch?

[Mike Kienenberger <mk...@gmail.com>]

The SVN commits will automatically be picked up if you add a reference
to them in your commit log message.  For example, here's one that
propagated to two different issues.

=====================================
TRINIDAD-654 & TRINIDAD-651
Fixed close-icon on l/w dialogs.
Also added new skin selectors for skinning dialogs seperately from panelPopup.
=====================================


On 8/27/07, Andrew Robinson <an...@gmail.com> wrote:
> Some open source projects differ on code responsibility and bug
> fixing, and I want to make sure I don't step on people's toes. Lately
> I have been using Trinidad on a side project and have been finding
> bugs and areas for small enhancements, as many will realize.
>
> I want to know if it is more customary in the Trinidad project to
> create SVN patches attached to bugs or to just commit the fix right
> into SVN if I am not the original author?
>
> If direct committing is okay, is there a wiki or page that describes
> anything that should be done to ensure that JIRA tracks the SVN commit
> for a given bug?
>
> Thank you,
> Andrew
>