You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/05 14:07:46 UTC
[GitHub] [apisix] shuaijinchao commented on a change in pull request #6502: feat: rerun rewrite phase for newly added plugins in consumer
shuaijinchao commented on a change in pull request #6502:
URL: https://github.com/apache/apisix/pull/6502#discussion_r820107618
##########
File path: apisix/plugin.lua
##########
@@ -365,17 +365,7 @@ function _M.filter(ctx, conf, plugins, route_conf, runned_plugins)
return plugins or core.tablepool.fetch("plugins", 0, 0)
end
- local unrunn_plugins
- local runned_plugins_names
- if runned_plugins and type(runned_plugins) == "table" then
- runned_plugins_names = core.table.new(#runned_plugins / 2, 0)
- for i = 1, #runned_plugins, 2 do
- core.table.insert(runned_plugins_names, runned_plugins[i].name)
- end
- unrunn_plugins = core.table.new(4, 0)
- end
-
- local route_plugin_conf = route_conf and route_conf.value and route_conf.value.plugins
+ local route_plugin_conf = route_conf and route_conf.value.plugins
Review comment:
```suggestion
local route_plugin_conf = route_conf and route_conf.value and route_conf.value.plugins
```
Keeping the old way should be more rigorous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org