You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/12/26 21:40:42 UTC

Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-3134
    https://issues.apache.org/jira/browse/RANGER-3134


Repository: ranger


Description
-------

RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR


Diffs
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosHttpClientBuilder.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosKeytabUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KeytabConfiguration.java PRE-CREATION 


Diff: https://reviews.apache.org/r/73108/diff/1/


Testing
-------

Verified in kerberos cluster for audit to solr for various services.


Thanks,

Ramesh Mani


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/#review222399
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 31, 2020, 7:26 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73108/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2020, 7:26 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3134
>     https://issues.apache.org/jira/browse/RANGER-3134
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 
> 
> 
> Diff: https://reviews.apache.org/r/73108/diff/3/
> 
> 
> Testing
> -------
> 
> Verified in kerberos cluster for audit to solr for various services.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/
-----------------------------------------------------------

(Updated Dec. 31, 2020, 7:26 a.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Fixed review comments


Bugs: RANGER-3134
    https://issues.apache.org/jira/browse/RANGER-3134


Repository: ranger


Description
-------

RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
  security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 


Diff: https://reviews.apache.org/r/73108/diff/3/

Changes: https://reviews.apache.org/r/73108/diff/2-3/


Testing
-------

Verified in kerberos cluster for audit to solr for various services.


Thanks,

Ramesh Mani


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Ramesh Mani <rm...@hortonworks.com>.

> On Dec. 31, 2020, 6:33 a.m., bhavik patel wrote:
> > Check this module might be useful and will be common for both the Audit source
> 
> bhavik patel wrote:
>     "agents-cred/src/main/java/org/apache/ranger/authorization/credutils/kerberos"

We would like to use the InMemoryJAASConfiguration as much as possible to get the ticket cache also used along with kerberos authentication, this will keep it simple.


- Ramesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/#review222395
-----------------------------------------------------------


On Dec. 29, 2020, 8:34 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73108/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2020, 8:34 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3134
>     https://issues.apache.org/jira/browse/RANGER-3134
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 
> 
> 
> Diff: https://reviews.apache.org/r/73108/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in kerberos cluster for audit to solr for various services.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/#review222395
-----------------------------------------------------------



Check this module might be useful and will be common for both the Audit source

- bhavik patel


On Dec. 29, 2020, 8:34 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73108/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2020, 8:34 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3134
>     https://issues.apache.org/jira/browse/RANGER-3134
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 
> 
> 
> Diff: https://reviews.apache.org/r/73108/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in kerberos cluster for audit to solr for various services.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/#review222393
-----------------------------------------------------------


Fix it, then Ship it!





agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java
Lines 22 (patched)
<https://reviews.apache.org/r/73108/#comment311447>

    It looks like ConfigurationUtil is not used. If true, please consider removing this interface.


- Madhan Neethiraj


On Dec. 29, 2020, 8:34 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73108/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2020, 8:34 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3134
>     https://issues.apache.org/jira/browse/RANGER-3134
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 
> 
> 
> Diff: https://reviews.apache.org/r/73108/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in kerberos cluster for audit to solr for various services.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/
-----------------------------------------------------------

(Updated Dec. 29, 2020, 8:34 p.m.)


Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Review comments addressed


Bugs: RANGER-3134
    https://issues.apache.org/jira/browse/RANGER-3134


Repository: ranger


Description
-------

RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR


Diffs (updated)
-----

  agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/InMemoryJAASConfiguration.java cc61fb88a 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosJAASConfigUser.java PRE-CREATION 
  agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/patch/cliutil/DbToSolrMigrationUtil.java c20bcfab8 
  security-admin/src/main/java/org/apache/ranger/solr/SolrMgr.java f4eab6433 


Diff: https://reviews.apache.org/r/73108/diff/2/

Changes: https://reviews.apache.org/r/73108/diff/1-2/


Testing
-------

Verified in kerberos cluster for audit to solr for various services.


Thanks,

Ramesh Mani


Re: Review Request 73108: RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73108/#review222388
-----------------------------------------------------------




agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Line 77 (original), 84 (patched)
<https://reviews.apache.org/r/73108/#comment311440>

    PROC_SOLR_PRINCIPAL =>  PROP_SOLR_PRINCIPAL



agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Lines 91 (patched)
<https://reviews.apache.org/r/73108/#comment311441>

    Please add suffix _MS or  _IN_MS, similar to #89 and #90.



agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Line 218 (original), 127 (patched)
<https://reviews.apache.org/r/73108/#comment311442>

    Consider moving #127 to finally block.



agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
Lines 191 (patched)
<https://reviews.apache.org/r/73108/#comment311443>

    Is synchronized needed at  method level, given block at #194 is synchronized?



agents-audit/src/main/java/org/apache/ranger/audit/utils/KeytabConfiguration.java
Lines 34 (patched)
<https://reviews.apache.org/r/73108/#comment311446>

    Consider reusing InMemoryJAASConfiguration, instead of introducing this new classs KeytabConfiguration.


- Madhan Neethiraj


On Dec. 26, 2020, 9:40 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73108/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2020, 9:40 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3134
>     https://issues.apache.org/jira/browse/RANGER-3134
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3134:Remove global JAAS Configuration for Ranger auditing to SOLR
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java cf0ba77aa 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractKerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/ConfigurationUtil.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosAction.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosHttpClientBuilder.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosKeytabUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KerberosUser.java PRE-CREATION 
>   agents-audit/src/main/java/org/apache/ranger/audit/utils/KeytabConfiguration.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73108/diff/1/
> 
> 
> Testing
> -------
> 
> Verified in kerberos cluster for audit to solr for various services.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>