You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2016/11/23 15:50:06 UTC
Review Request 54032: Enable CBO on interval literals
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54032/
-----------------------------------------------------------
Review request for hive and pengcheng xiong.
Bugs: HIVE-15258
https://issues.apache.org/jira/browse/HIVE-15258
Repository: hive-git
Description
-------
Currently it throws exception and follows non CBO path
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java f6b4124
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java cb7bc26
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java cb86934
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java a47010d
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 96dab3b
ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 0dd8fc5
ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 8e3bc39
ql/src/test/results/clientpositive/vector_interval_1.q.out f18e56c
ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 5d1dca6
Diff: https://reviews.apache.org/r/54032/diff/
Testing
-------
Existing regression suite
Thanks,
Ashutosh Chauhan
Re: Review Request 54032: Enable CBO on interval literals
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54032/#review157171
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java (line 488)
<https://reviews.apache.org/r/54032/#comment227612>
We should file a Calcite bug for this.
- pengcheng xiong
On Nov. 23, 2016, 3:50 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54032/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2016, 3:50 p.m.)
>
>
> Review request for hive and pengcheng xiong.
>
>
> Bugs: HIVE-15258
> https://issues.apache.org/jira/browse/HIVE-15258
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently it throws exception and follows non CBO path
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java f6b4124
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java cb7bc26
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java cb86934
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java a47010d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 96dab3b
> ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 0dd8fc5
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 8e3bc39
> ql/src/test/results/clientpositive/vector_interval_1.q.out f18e56c
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 5d1dca6
>
> Diff: https://reviews.apache.org/r/54032/diff/
>
>
> Testing
> -------
>
> Existing regression suite
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 54032: Enable CBO on interval literals
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54032/#review157173
-----------------------------------------------------------
Ship it!
Ship It!
- pengcheng xiong
On Nov. 23, 2016, 3:50 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54032/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2016, 3:50 p.m.)
>
>
> Review request for hive and pengcheng xiong.
>
>
> Bugs: HIVE-15258
> https://issues.apache.org/jira/browse/HIVE-15258
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Currently it throws exception and follows non CBO path
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/CalciteSemanticException.java f6b4124
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java cb7bc26
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java cb86934
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/TypeConverter.java a47010d
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 96dab3b
> ql/src/test/results/clientpositive/llap/vector_interval_1.q.out 0dd8fc5
> ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out 8e3bc39
> ql/src/test/results/clientpositive/vector_interval_1.q.out f18e56c
> ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out 5d1dca6
>
> Diff: https://reviews.apache.org/r/54032/diff/
>
>
> Testing
> -------
>
> Existing regression suite
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>