You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/12/13 16:19:05 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #3123: Modified FileCompactor to ignore TABLE_MAJC_OUTPUT_DROP_CACHE for minc
dlmarion opened a new pull request, #3123:
URL: https://github.com/apache/accumulo/pull/3123
FileCompactor is also used by MinorCompactor then when the property TABLE_MAJC_OUTPUT_DROP_CACHE is set to true, the output file was being created with CreateFlag.SYNC_BLOCK and setDropBehind. This change modifies FileCompactor to not do that for minc output files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3123: Modified FileCompactor to ignore TABLE_MAJC_OUTPUT_DROP_CACHE for minc
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #3123:
URL: https://github.com/apache/accumulo/pull/3123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3123: Modified FileCompactor to ignore TABLE_MAJC_OUTPUT_DROP_CACHE for minc
Posted by GitBox <gi...@apache.org>.
dlmarion commented on PR #3123:
URL: https://github.com/apache/accumulo/pull/3123#issuecomment-1348997918
To summarize the multiple tickets revolving around dropping pages from the page cache:
#3077 - calls setDropBehind() on the FSDataInputStream and FSDataOutputStream when reading and writing WAL files. Property.TSERV_WAL_SYNC can be set to true to enable the WAL output file to be created with CreateFlag.SYNC_BLOCK
#3079 - calls FSDataInputStream.setDropBehind() on the input files read in FileCompactor.
#3083 - modifies FileCompactor to create output file using CreateFlag.SYNC_BLOCK and setDropBehind() when Property.TABLE_MAJC_OUTPUT_DROP_CACHE is set to true.
I didn't realize at the time of #3083 that the FileCompactor was used for writing minc files also. This PR is for discussion about what the right approach is for minc output files. Should we leave their pages in the cache? Should we drop them like majc files? Should we make it configurable via a new property Property.TABLE_MINC_OUTPUT_DROP_CACHE ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org