[jira] [Commented] (JCLOUDS-1117) Some values from DockerTemplateOptions.configBuilder are replaced in DockerComputeServiceAdapter

["Josef Cacek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298637#comment-15298637 ] 

Josef Cacek commented on JCLOUDS-1117:
--------------------------------------

PR sent (together with JCLOUDS-1118) - https://github.com/jclouds/jclouds-labs/pull/274

> Some values from DockerTemplateOptions.configBuilder are replaced in DockerComputeServiceAdapter
> ------------------------------------------------------------------------------------------------
>
>                 Key: JCLOUDS-1117
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1117
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-labs
>            Reporter: Josef Cacek
>              Labels: docker
>
> *Issue description:*
> If I want to use advanced Docker configuration by providing {{DockerTemplateOptions.configBuilder(...)}}, then some values are replaced (exposed ports, port bindings) by configuration from the {{DockerTemplateOptions}} configuration. This is wrong, because by providing the {{Config.Builder}} instance I say I want to use exactly this configuration.
> *Expected state:*
> If the {{Config.Builder}} instance is provided, then it's used directly (unchanged).
> *Suggested fix:*
> The condition block {{if (containerConfigBuilder == null) \{}}  should be extended. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)