You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/08/16 17:53:38 UTC

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #841: GEODE-9501: Works with toolset Microsoft v142

pdxcodemonkey commented on a change in pull request #841:
URL: https://github.com/apache/geode-native/pull/841#discussion_r689741407



##########
File path: ci/base/base.yml
##########
@@ -61,7 +61,7 @@ builds:
     with_dot_net: #@ True
     #@yaml/map-key-override
     params:
-      CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64 -DCMAKE_SYSTEM_VERSION=10.0.16299.0"

Review comment:
       Okay, so some Googling tells me that for cmake 3.13 or newer, we need to ditch "Win64" in the -G parameter and use "-A x64" to configure 64-bit builds:  https://stackoverflow.com/questions/28350214/how-to-build-x86-and-or-x64-on-windows-from-command-line-with-cmake
   And "-T host=x64" is used only to specifically force 64-bit toolset, so I don't suppose this is anything other than maybe a small performance hit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org