You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/01/21 02:37:10 UTC
[GitHub] [trafficserver] AD5GB opened a new pull request #8626: Fix 32bit build failure on Odroid Xu-4
AD5GB opened a new pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626
It's and oddball device but ATS now builds and runs well on it.
Also built and tested on OpenSuSE Tumbleweed, Fedora-35 and Centos-8 aarch64 and x86_64 platforms.
Signed-off-by: Randy DuCharme <ra...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#issuecomment-1018648942
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#discussion_r789933560
##########
File path: proxy/logging/LogUtils.cc
##########
@@ -599,7 +599,7 @@ LogUtils::file_is_writeable(const char *full_filename, off_t *size_bytes, bool *
if (e < 0) {
ret_val = -1;
} else {
- if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) {
+ if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) {
Review comment:
Ah, thanks @ywkaras. I was wondering how this built before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 removed a comment on pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
masaori335 removed a comment on pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#issuecomment-1018157238
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#issuecomment-1018157238
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#issuecomment-1018648942
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#discussion_r789859145
##########
File path: proxy/logging/LogUtils.cc
##########
@@ -599,7 +599,7 @@ LogUtils::file_is_writeable(const char *full_filename, off_t *size_bytes, bool *
if (e < 0) {
ret_val = -1;
} else {
- if (limit_data.rlim_cur != static_cast<rlim_t> RLIM_INFINITY) {
+ if (limit_data.rlim_cur != static_cast<rlim_t>(RLIM_INFINITY)) {
Review comment:
Thanks, this is good code cleanup in general. I think the only reason it hasn't broken for x86 build is that RLIM_INFINITY is implemented as macro with parentheses enclosing the value:
```
# define RLIM_INFINITY ((__rlim_t) -1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8626: Fix 32bit build failure on Odroid Xu-4
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8626:
URL: https://github.com/apache/trafficserver/pull/8626#issuecomment-1021596599
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org