You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/03/02 23:34:12 UTC

[kudu-CR] KUDU-1347. Improve licensing documentation

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2417

to review the following change.

Change subject: KUDU-1347. Improve licensing documentation
......................................................................

KUDU-1347. Improve licensing documentation

This addresses a few issues and suggestions raised on our
0.7.0 release candidate vote:

- Many of the licenses previously mentioned in LICENSE.txt do not actually
  require that they be reproduced in binary distributions. Since we already
  include the license text in the source headers themselves, we can just
  refer the reader to the source.

  For those licenses which require some form of notice or attribution in
  binary distributions, we continue to copy-paste the license text into
  the LICENSE.txt file.

- Copy the CMake BSD license notice into the FindProtobuf.cmake file.
  Even though we substantially rewrote it, it could be considered a
  derived work.

- Relocate the copyright notices for Slice.java and Slices.java into the
  source header for those files, so that we can remove the extra copy of the
  Apache license from LICENSE.txt.

  Similarly, relocate the authorship information for HdrHistogram into the
  source code. Since it's a public domain library, it doesn't require
  any attribution.

- Remove a stray Cloudera copyright notice from python/Makefile

- Add a copy of the Boost license to the thirdparty/boost_uuid/ directory
  and reference it from the top-level LICENSE instead of copying it. This
  license does not require attribution in binary distributions.

- Fix the reference to the WebRTC code to include random.h (not just
  random-util.cc)

Change-Id: I95e5a86128e677839c84e209ba4f7c910c33517d
---
M LICENSE.txt
M cmake_modules/FindProtobuf.cmake
M java/kudu-client/src/main/java/org/kududb/util/Slice.java
M java/kudu-client/src/main/java/org/kududb/util/Slices.java
M python/Makefile
M src/kudu/util/hdr_histogram.cc
M src/kudu/util/hdr_histogram.h
M src/kudu/util/url-coding.cc
A thirdparty/boost_uuid/LICENSE.txt
9 files changed, 118 insertions(+), 182 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/2417/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2417
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95e5a86128e677839c84e209ba4f7c910c33517d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans