You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/19 05:15:56 UTC

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #594: [WIP] Bug Fixes

davidjumani opened a new pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594


   Fixes :
   #588


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677465330


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473835850



##########
File path: src/views/compute/wizard/ComputeSelection.vue
##########
@@ -106,7 +104,7 @@ export default {
     },
     minMemory: {
       type: Number,
-      default: 1
+      default: 16

Review comment:
       Min value to 0?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472949313



##########
File path: src/config/eventBus.js
##########
@@ -0,0 +1,2 @@
+import Vue from 'vue'
+export default new Vue()

Review comment:
       @davidjumani what's the purpose of this, or you exploring some idea?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-678085713


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/594 (JID-3310)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472951520



##########
File path: src/config/eventBus.js
##########
@@ -0,0 +1,2 @@
+import Vue from 'vue'
+export default new Vue()

Review comment:
       Used as an event bus to transmit a refresh event between the deployvm and autogen views since it's not a popup form and can't provide / inject the parentFetchData method




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677464559


   @blueorangutan package 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-678044896


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #594: Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-678088197


   @rhtyd Ready to merge!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473835438



##########
File path: src/views/compute/DeployVM.vue
##########
@@ -193,7 +193,7 @@
                       :isConstrained="'serviceofferingdetails' in serviceOffering"
                       :minCpu="'serviceofferingdetails' in serviceOffering ? serviceOffering.serviceofferingdetails.mincpunumber*1 : 1"
                       :maxCpu="'serviceofferingdetails' in serviceOffering ? serviceOffering.serviceofferingdetails.maxcpunumber*1 : Number.MAX_SAFE_INTEGER"
-                      :minMemory="'serviceofferingdetails' in serviceOffering ? serviceOffering.serviceofferingdetails.minmemory*1 : 1"
+                      :minMemory="'serviceofferingdetails' in serviceOffering ? serviceOffering.serviceofferingdetails.minmemory*1 : 16"

Review comment:
       Could we set this to 0?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#issuecomment-677470890


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/594 (JID-3284)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473834363



##########
File path: src/config/eventBus.js
##########
@@ -0,0 +1,2 @@
+import Vue from 'vue'

Review comment:
       can you add a license




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r474414311



##########
File path: src/views/AutogenView.vue
##########
@@ -143,7 +143,6 @@
           <a-form
             :form="form"
             @submit="handleSubmit"
-            v-show="dataView || !currentAction.groupAction || this.selectedRowKeys.length === 0"

Review comment:
       Done!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #594:
URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r473837733



##########
File path: src/views/AutogenView.vue
##########
@@ -143,7 +143,6 @@
           <a-form
             :form="form"
             @submit="handleSubmit"
-            v-show="dataView || !currentAction.groupAction || this.selectedRowKeys.length === 0"

Review comment:
       @davidjumani can you check if we can put focus on a-inpur for the auto-generated form?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org