You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2017/01/19 01:23:49 UTC
Review Request 55696: CMake: Separated Mesos system headers from
Mesos API headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55696/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
Bugs: MESOS-3932
https://issues.apache.org/jira/browse/MESOS-3932
Repository: mesos
Description
-------
MESOS-3932 specifies a bug that causes spurious warnings to be printed
when building Mesos.
Many of these warnings can be eliminated simply by correctly marking off
the third-party dependencies as `SYSTEM` headers when we specify the
include path.
This commit will thus separate out the headers of Mesos's
third-party dependencies from the core Mesos API headers, and
include them as `SYSTEM` headers.
Notably, we choose to include Stout's and Libprocess's headers as
third-party system headers, since the goal is for them to be completely
independent projects.
Diffs
-----
src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
src/docker/CMakeLists.txt 892370d603d42b649afbf05deece5e0b1d97ee98
src/master/CMakeLists.txt a9fb34fc7099f05e279ee0506dd18bc0745d546c
src/master/cmake/MasterConfigure.cmake 3d316d6ff2910fc360b0faecb5e6ac9687a77883
src/slave/CMakeLists.txt 03466bda934290ce41fa6408d35ccae10c9a6f32
src/slave/cmake/AgentConfigure.cmake 1582127ccce773af6031a5b09252192b05a13cdc
src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5
src/tests/cmake/MesosTestsConfigure.cmake 8d416388a8e45a2832ae3841b58541ba5b0613bc
Diff: https://reviews.apache.org/r/55696/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 55696: CMake: Separated Mesos system headers from
Mesos API headers.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55696/#review163370
-----------------------------------------------------------
src/CMakeLists.txt (line 361)
<https://reviews.apache.org/r/55696/#comment234784>
I assume you meant to add a `SYSTEM` here?
src/docker/CMakeLists.txt (line 28)
<https://reviews.apache.org/r/55696/#comment234785>
And here.
src/slave/CMakeLists.txt (line 31)
<https://reviews.apache.org/r/55696/#comment234786>
And here.
src/tests/CMakeLists.txt (line 226)
<https://reviews.apache.org/r/55696/#comment234787>
And here.
- Joseph Wu
On Jan. 18, 2017, 5:23 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55696/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5:23 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.
>
>
> Bugs: MESOS-3932
> https://issues.apache.org/jira/browse/MESOS-3932
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MESOS-3932 specifies a bug that causes spurious warnings to be printed
> when building Mesos.
>
> Many of these warnings can be eliminated simply by correctly marking off
> the third-party dependencies as `SYSTEM` headers when we specify the
> include path.
>
> This commit will thus separate out the headers of Mesos's
> third-party dependencies from the core Mesos API headers, and
> include them as `SYSTEM` headers.
>
> Notably, we choose to include Stout's and Libprocess's headers as
> third-party system headers, since the goal is for them to be completely
> independent projects.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c
> src/docker/CMakeLists.txt 892370d603d42b649afbf05deece5e0b1d97ee98
> src/master/CMakeLists.txt a9fb34fc7099f05e279ee0506dd18bc0745d546c
> src/master/cmake/MasterConfigure.cmake 3d316d6ff2910fc360b0faecb5e6ac9687a77883
> src/slave/CMakeLists.txt 03466bda934290ce41fa6408d35ccae10c9a6f32
> src/slave/cmake/AgentConfigure.cmake 1582127ccce773af6031a5b09252192b05a13cdc
> src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5
> src/tests/cmake/MesosTestsConfigure.cmake 8d416388a8e45a2832ae3841b58541ba5b0613bc
>
> Diff: https://reviews.apache.org/r/55696/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>