You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/11/24 09:55:43 UTC

[GitHub] [thrift] cfriedt commented on pull request #2733: Fix cpp header issues

cfriedt commented on PR #2733:
URL: https://github.com/apache/thrift/pull/2733#issuecomment-1326212660

   > I merged it because it changes the situation to the better. However I would say there is sth else:
   > https://app.travis-ci.com/github/apache/thrift/jobs/589165720
   > https://app.travis-ci.com/github/apache/thrift/jobs/589165723
   > 
   > The c_glib tests use a C++ server to test against. Seems there are some adjustments needed too, because now it complains about missing sleep(), fork() and throw()
   > 
   
   @Jens-G - I noticed that as well. Shall I put together a fix for c_glib? I'm not sure yet what the root cause is yet.
   
   (Sorry for the late response, i had left my comment in draft by accident)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org