You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/05/02 18:58:49 UTC

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/870

    [HOTFIX] Authentication doesn't work after upgrade to jetty9

    ### What is this PR for?
    After the jetty9 upgrade https://github.com/apache/incubator-zeppelin/pull/831, authentication seems doesn't work. This PR fixes problem by applying shiro filter only /api/*
    
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Fix
    
    ### What is the Jira issue?
    
    ### How should this be tested?
    enable authentication (edit conf/shiro.ini) and try login
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin jetty9_hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #870
    
----
commit ea198c4a24d2901b70df6cb89f7f8781d59ab483
Author: Lee moon soo <mo...@apache.org>
Date:   2016-05-02T16:55:53Z

    Apply shiro filter from /* to only /api/*

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216429543
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216629763
  
    Tested, works for now, and user session remains after page refresh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216427588
  
    Update: login information does not stays after page refresh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216457974
  
    [ZEPPELIN-836](https://issues.apache.org/jira/browse/ZEPPELIN-836) was created to address CI issues


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216627328
  
    After couple of different trial, figured out apply shiro filter to `/*` as before, and use authcBasic (default browser user auth dialog) instead of authc (bootstrap user auth dialog) is the simplest fix at the moment. 
    
    It's the dialog is bit ugly but authentication is functioning as before. 
    I have created a separate issue to bringing our fancy auth dialog back https://issues.apache.org/jira/browse/ZEPPELIN-837


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216632774
  
    Thanks @prabhjyotsingh taking a look. I'm merging it into master as a hotfix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216476403
  
    Can you try to re-trigger CI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216432006
  
    \U0001f44d  Looks great, thank you for hotfixing!
    
    It looks like it's flaky webapp build somehow.
    
    ```
    olve@1.1.7, fileset@0.2.1, escodegen@1.8.0, js-yaml@3.6.0, handlebars@4.0.5)
    [ERROR] npm ERR! Linux 3.13.0-40-generic
    [ERROR] npm ERR! argv "/home/travis/build/apache/incubator-zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/incubator-zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "install" "--color=false"
    [ERROR] npm ERR! node v0.12.13
    [ERROR] npm ERR! npm  v2.15.0
    [ERROR] 
    [ERROR] npm ERR! Callback called more than once.
    [ERROR] npm ERR! 
    [ERROR] npm ERR! If you need help, you may report this error at:
    [ERROR] npm ERR!     <https://github.com/npm/npm/issues>
    [ERROR] 
    [ERROR] npm ERR! Please include the following file with any support request:
    [ERROR] npm ERR!     /home/travis/build/apache/incubator-zeppelin/zeppelin-web/npm-debug.log
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO] 
    
    [INFO] Zeppelin: web Application .......................... FAILURE [10:49 min]
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/870#issuecomment-216426281
  
    Tested, LGTM.
    CI fails for unrelated reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Authentication doesn't w...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/870


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---