You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/18 10:28:14 UTC

[jira] [Commented] (TAJO-920) Add FIRST_VALUE and LAST_VALUE window functions

    [ https://issues.apache.org/jira/browse/TAJO-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251421#comment-14251421 ] 

ASF GitHub Bot commented on TAJO-920:
-------------------------------------

GitHub user sirpkt opened a pull request:

    https://github.com/apache/tajo/pull/308

    TAJO-920: Add FIRST_VALUE and LAST_VALUE window functions

    I implemented first_value() and last_value() for TEXT type first.
    
    - It adds first_value, last_value keyword in lexer and parser and modifies SQLAnalyzer to call corresponding functions.
    - first_value() is defined as window function, however, last_value() is defined as aggregation function because it needs to reach the end row of the given column to determine the last value.
    - With current window function structure, every window function name should be hardcoded in ExprAnnotator.java, so do it for first_value()


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sirpkt/tajo TAJO-920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/308.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #308
    
----
commit d07fdb3ccdf4b929d8562a4fc3535f7a3df68280
Author: sirpkt <si...@apache.org>
Date:   2014-12-18T08:03:51Z

    TAJO-920: Add FIRST_VALUE and LAST_VALUE window functions

commit 7464d62460bc7af2b268541c0be57d57d7e899ce
Author: sirpkt <si...@apache.org>
Date:   2014-12-18T09:16:26Z

    TAJO-920: Add FIRST_VALUE and LAST_VALUE window functions

----


> Add FIRST_VALUE and LAST_VALUE window functions
> -----------------------------------------------
>
>                 Key: TAJO-920
>                 URL: https://issues.apache.org/jira/browse/TAJO-920
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: physical operator, planner/optimizer
>            Reporter: Hyunsik Choi
>             Fix For: window function, 0.11
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)